improve team member handling (#3097)

tests/API/TeamControllerTest.php

@@ -170,6 +170,13 @@ class TeamControllerTest extends APIControllerBaseTest
         $this->assertNotEmpty($result['id']);
         self::assertCount(3, $result['users']);
 
+        $this->request($client, '/api/teams/' . $updateId);
+        $result = json_decode($client->getResponse()->getContent(), true);
+
+        $this->assertIsArray($result);
+        self::assertApiResponseTypeStructure('TeamEntity', $result);
+        self::assertCount(3, $result['users']);
+
         self::assertFalse($result['members'][1]['teamlead']);
         self::assertEquals(1, $result['members'][1]['user']['id']);
         self::assertEquals('clara_customer', $result['members'][1]['user']['username']);

tests/Entity/TeamTest.php

@@ -92,6 +92,9 @@ class TeamTest extends TestCase
         self::assertCount(0, $sut->getMembers());
         self::assertFalse($sut->isTeamlead($user));
 
+        $member = new TeamMember();
+        $member->setUser($user);
+
         $sut->addMember($member);
         $member->setTeamlead(true);
         self::assertTrue($sut->isTeamlead($user));

tests/Entity/UserTest.php

@@ -449,6 +449,9 @@ class UserTest extends TestCase
 
         self::assertFalse($sut->isTeamleadOf($team));
 
+        $member = new TeamMember();
+        $member->setTeam($team);
+
         $sut->addMembership($member);
         self::assertCount(1, $sut->getMemberships());
         self::assertFalse($sut->isTeamleadOf($team));