Prevent bookings with same start / stop time (#3304)

src/Configuration/SystemConfiguration.php

@@ -237,6 +237,11 @@ class SystemConfiguration implements SystemBundleConfiguration
         return (bool) $this->find('timesheet.rules.allow_future_times');
     }
 
+    public function isTimesheetAllowZeroDuration(): bool
+    {
+        return (bool) $this->find('timesheet.rules.allow_zero_duration');
+    }
+
     public function isTimesheetAllowOverbookingBudget(): bool
     {
         return (bool) $this->find('timesheet.rules.allow_overbooking_budget');

src/Controller/SystemConfigurationController.php

@@ -338,6 +338,10 @@ final class SystemConfigurationController extends AbstractController
                         ->setName('timesheet.rules.allow_future_times')
                         ->setType(CheckboxType::class)
                         ->setTranslationDomain('system-configuration'),
+                    (new Configuration())
+                        ->setName('timesheet.rules.allow_zero_duration')
+                        ->setType(CheckboxType::class)
+                        ->setTranslationDomain('system-configuration'),
                     (new Configuration())
                         ->setName('timesheet.rules.allow_overlapping_records')
                         ->setType(CheckboxType::class)

src/DependencyInjection/Configuration.php

@@ -243,6 +243,9 @@ class Configuration implements ConfigurationInterface
                         ->booleanNode('allow_future_times')
                             ->defaultTrue()
                         ->end()
+                        ->booleanNode('allow_zero_duration')
+                            ->defaultTrue()
+                        ->end()
                         ->booleanNode('allow_overbooking_budget')
                             ->defaultTrue()
                         ->end()

src/Validator/Constraints/TimesheetZeroDuration.php

@@ -0,0 +1,26 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Validator\Constraints;
+
+final class TimesheetZeroDuration extends TimesheetConstraint
+{
+    public const ZERO_DURATION_ERROR = 'kimai-timesheet-zero-duration-01';
+
+    protected static $errorNames = [
+        self::ZERO_DURATION_ERROR => 'Duration cannot be zero.',
+    ];
+
+    public $message = 'Duration cannot be zero.';
+
+    public function getTargets()
+    {
+        return self::CLASS_CONSTRAINT;
+    }
+}

src/Validator/Constraints/TimesheetZeroDurationValidator.php

@@ -0,0 +1,56 @@
+<?php
+
+/*
+ * This file is part of the Kimai time-tracking app.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Validator\Constraints;
+
+use App\Configuration\SystemConfiguration;
+use App\Entity\Timesheet as TimesheetEntity;
+use Symfony\Component\Validator\Constraint;
+use Symfony\Component\Validator\ConstraintValidator;
+use Symfony\Component\Validator\Exception\UnexpectedTypeException;
+
+final class TimesheetZeroDurationValidator extends ConstraintValidator
+{
+    /**
+     * @var SystemConfiguration
+     */
+    private $configuration;
+
+    public function __construct(SystemConfiguration $configuration)
+    {
+        $this->configuration = $configuration;
+    }
+
+    /**
+     * @param TimesheetEntity $timesheet
+     * @param Constraint $constraint
+     */
+    public function validate($timesheet, Constraint $constraint)
+    {
+        if (!($constraint instanceof TimesheetZeroDuration)) {
+            throw new UnexpectedTypeException($constraint, TimesheetZeroDuration::class);
+        }
+
+        if (!\is_object($timesheet) || !($timesheet instanceof TimesheetEntity)) {
+            throw new UnexpectedTypeException($timesheet, TimesheetEntity::class);
+        }
+
+        if ($this->configuration->isTimesheetAllowZeroDuration()) {
+            return;
+        }
+
+        if ($timesheet->getDuration() == 0) {
+            $this->context->buildViolation($constraint->message)
+                ->atPath('duration')
+                ->setTranslationDomain('validators')
+                ->setCode(TimesheetZeroDuration::ZERO_DURATION_ERROR)
+                ->addViolation();
+        }
+    }
+}