configurable print export (#2657)

tests/Controller/ExportControllerTest.php

@@ -233,13 +233,14 @@ class ExportControllerTest extends ControllerBaseTest
 
         $response = $client->getResponse();
         $this->assertTrue($response->isSuccessful());
+        $content = $response->getContent();
         $node = $client->getCrawler()->filter('body');
         $this->assertEquals(1, $node->count());
 
         // poor mans assertions ;-)
         $this->assertStringContainsString('export_print', $node->getIterator()[0]->getAttribute('class'));
-        $this->assertStringContainsString('<h2>', $response->getContent());
-        $this->assertStringContainsString('<h3>Summary</h3>', $response->getContent());
+        $this->assertStringContainsString('<h2 id="doc-title" contenteditable="true"', $content);
+        $this->assertStringContainsString('<h3 id="doc-summary" contenteditable="true" data-original="Summary">Summary</h3>', $content);
 
         $node = $client->getCrawler()->filter('section.export div#export-records table.dataTable tbody tr');
         // 20 rows + the summary footer

tests/Export/Renderer/HtmlRendererTest.php

@@ -52,8 +52,8 @@ class HtmlRendererTest extends AbstractRendererTest
 
         $content = $response->getContent();
 
-        $this->assertStringContainsString('<h2>', $content);
-        $this->assertStringContainsString('<h3>Summary</h3>', $content);
+        $this->assertStringContainsString('<h2 id="doc-title" contenteditable="true"', $content);
+        $this->assertStringContainsString('<h3 id="doc-summary" contenteditable="true" data-original="Summary">Summary</h3>', $content);
         $this->assertEquals(1, substr_count($content, 'id="export-summary"'));
         $this->assertEquals(1, substr_count($content, 'id="export-records"'));
         $this->assertEquals(1, substr_count($content, 'id="summary-project"'));
@@ -61,7 +61,7 @@ class HtmlRendererTest extends AbstractRendererTest
 
         $this->assertStringContainsString('<td>Customer Name</td>', $content);
         $this->assertStringContainsString('<td>project name</td>', $content);
-        $this->assertStringContainsString('<td class="duration summary-duration">01:50 h</td>', $content);
+        $this->assertStringContainsString('<span class="duration-format" data-duration="6600">01:50 h</span>', $content);
         $this->assertStringContainsString('<td class="cost summary-rate">€2,437.12</td>', $content);
 
         // 5 times in the "full list" and once in the "summary with activities"

tests/Export/ServiceExportTest.php

@@ -9,12 +9,15 @@
 
 namespace App\Tests\Export;
 
+use App\Export\ExportRepositoryInterface;
 use App\Export\Renderer\HtmlRenderer;
 use App\Export\ServiceExport;
 use App\Export\Timesheet\HtmlRenderer as HtmlExporter;
 use App\Project\ProjectStatisticService;
+use App\Repository\Query\ExportQuery;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\EventDispatcher\EventDispatcher;
+use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 use Twig\Environment;
 
 /**
@@ -22,9 +25,16 @@ use Twig\Environment;
  */
 class ServiceExportTest extends TestCase
 {
+    private function createSut(): ServiceExport
+    {
+        $sut = new ServiceExport($this->createMock(EventDispatcherInterface::class));
+
+        return $sut;
+    }
+
     public function testEmptyObject()
     {
-        $sut = new ServiceExport();
+        $sut = $this->createSut();
 
         self::assertEmpty($sut->getRenderer());
         self::assertNull($sut->getRendererById('default'));
@@ -35,7 +45,7 @@ class ServiceExportTest extends TestCase
 
     public function testAddRenderer()
     {
-        $sut = new ServiceExport();
+        $sut = $this->createSut();
 
         $renderer = new HtmlRenderer($this->createMock(Environment::class), new EventDispatcher(), $this->createMock(ProjectStatisticService::class));
         $sut->addRenderer($renderer);
@@ -46,7 +56,7 @@ class ServiceExportTest extends TestCase
 
     public function testAddTimesheetExporter()
     {
-        $sut = new ServiceExport();
+        $sut = $this->createSut();
 
         $exporter = new HtmlExporter($this->createMock(Environment::class), new EventDispatcher(), $this->createMock(ProjectStatisticService::class));
         $sut->addTimesheetExporter($exporter);
@@ -54,4 +64,18 @@ class ServiceExportTest extends TestCase
         self::assertEquals(1, \count($sut->getTimesheetExporter()));
         self::assertSame($exporter, $sut->getTimesheetExporterById('print'));
     }
+
+    public function testAddExportRepository()
+    {
+        $sut = $this->createSut();
+
+        $repository = $this->createMock(ExportRepositoryInterface::class);
+        $repository->expects($this->once())->method('getExportItemsForQuery')->willReturn([]);
+        $sut->addExportRepository($repository);
+
+        $query = new ExportQuery();
+        $items = $sut->getExportItems($query);
+
+        self::assertEquals([], $items);
+    }
 }

tests/Repository/Query/TimesheetQueryTest.php

@@ -37,6 +37,7 @@ class TimesheetQueryTest extends BaseQueryTest
         $this->assertExported($sut);
         $this->assertSearchTerm($sut);
         $this->assertModifiedAfter($sut);
+        $this->assertMaxResults($sut);
 
         self::assertNull($sut->getBillable());
         self::assertFalse($sut->isBillable());
@@ -50,6 +51,13 @@ class TimesheetQueryTest extends BaseQueryTest
         $this->assertResetByFormError(new TimesheetQuery(), 'begin', 'DESC');
     }
 
+    protected function assertMaxResults(TimesheetQuery $sut)
+    {
+        self::assertNull($sut->getMaxResults());
+        $sut->setMaxResults(999);
+        self::assertEquals(999, $sut->getMaxResults());
+    }
+
     protected function assertUser(TimesheetQuery $sut)
     {
         self::assertNull($sut->getUser());