phpstan level 3, fixed deprecations, code cleanup (#811)

src/Export/Renderer/AbstractSpreadsheetRenderer.php

@@ -17,7 +17,7 @@ use PhpOffice\PhpSpreadsheet\Spreadsheet;
 use Symfony\Component\HttpFoundation\BinaryFileResponse;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\ResponseHeaderBag;
-use Symfony\Component\Translation\TranslatorInterface;
+use Symfony\Contracts\Translation\TranslatorInterface;
 
 abstract class AbstractSpreadsheetRenderer
 {
@@ -58,7 +58,7 @@ abstract class AbstractSpreadsheetRenderer
     }
 
     /**
-     * @param $amount
+     * @param int $amount
      * @return mixed
      */
     protected function getFormattedMoney($amount, $currency)
@@ -80,7 +80,7 @@ abstract class AbstractSpreadsheetRenderer
     }
 
     /**
-     * @param $seconds
+     * @param int $seconds
      * @return mixed
      */
     protected function getFormattedDuration($seconds)
@@ -209,7 +209,7 @@ abstract class AbstractSpreadsheetRenderer
     /**
      * @param Spreadsheet $spreadsheet
      * @return string
-     * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
+     * @throws \Exception
      */
     abstract protected function saveSpreadsheet(Spreadsheet $spreadsheet): string;
 }

src/Export/Renderer/CsvRenderer.php

@@ -33,12 +33,16 @@ class CsvRenderer extends AbstractSpreadsheetRenderer implements RendererInterfa
 
     /**
      * @param Spreadsheet $spreadsheet
-     * @return bool|string
-     * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
+     * @return string
+     * @throws \Exception
      */
     protected function saveSpreadsheet(Spreadsheet $spreadsheet): string
     {
         $filename = tempnam(sys_get_temp_dir(), 'kimai-export-csv');
+        if (false === $filename) {
+            throw new \Exception('Could not open temporary file');
+        }
+
         $writer = IOFactory::createWriter($spreadsheet, 'Csv');
         $writer->save($filename);
 

src/Export/Renderer/OdsRenderer.php

@@ -33,12 +33,16 @@ class OdsRenderer extends AbstractSpreadsheetRenderer implements RendererInterfa
 
     /**
      * @param Spreadsheet $spreadsheet
-     * @return bool|string
-     * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
+     * @return string
+     * @throws \Exception
      */
     protected function saveSpreadsheet(Spreadsheet $spreadsheet): string
     {
         $filename = tempnam(sys_get_temp_dir(), 'kimai-export-ods');
+        if (false === $filename) {
+            throw new \Exception('Could not open temporary file');
+        }
+
         $writer = IOFactory::createWriter($spreadsheet, 'Ods');
         $writer->save($filename);
 

src/Export/Renderer/XlsxRenderer.php

@@ -33,12 +33,16 @@ class XlsxRenderer extends AbstractSpreadsheetRenderer implements RendererInterf
 
     /**
      * @param Spreadsheet $spreadsheet
-     * @return bool|string
-     * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
+     * @return string
+     * @throws \Exception
      */
     protected function saveSpreadsheet(Spreadsheet $spreadsheet): string
     {
         $filename = tempnam(sys_get_temp_dir(), 'kimai-export-xlsx');
+        if (false === $filename) {
+            throw new \Exception('Could not open temporary file');
+        }
+
         $writer = IOFactory::createWriter($spreadsheet, 'Xlsx');
         $writer->save($filename);