phpstan level 3, fixed deprecations, code cleanup (#811)

src/Invoice/Renderer/AbstractRenderer.php

@@ -11,7 +11,7 @@ namespace App\Invoice\Renderer;
 
 use App\Twig\DateExtensions;
 use App\Twig\Extensions;
-use Symfony\Component\Translation\TranslatorInterface;
+use Symfony\Contracts\Translation\TranslatorInterface;
 
 abstract class AbstractRenderer
 {
@@ -63,8 +63,8 @@ abstract class AbstractRenderer
     }
 
     /**
-     * @param $amount
-     * @param $currency
+     * @param int $amount
+     * @param string $currency
      * @return string
      */
     protected function getFormattedMoney($amount, $currency)
@@ -82,7 +82,7 @@ abstract class AbstractRenderer
     }
 
     /**
-     * @param $seconds
+     * @param int $seconds
      * @return mixed
      */
     protected function getFormattedDuration($seconds)

src/Invoice/Renderer/AbstractSpreadsheetRenderer.php

@@ -19,9 +19,11 @@ use Symfony\Component\HttpFoundation\Response;
 abstract class AbstractSpreadsheetRenderer extends AbstractRenderer
 {
     /**
+     * Saves the Spreadhseet and returns the filename.
+     *
      * @param Spreadsheet $spreadsheet
-     * @return bool|string
-     * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
+     * @return string
+     * @throws \Exception
      */
     abstract protected function saveSpreadsheet(Spreadsheet $spreadsheet);
 
@@ -31,6 +33,7 @@ abstract class AbstractSpreadsheetRenderer extends AbstractRenderer
      * @param InvoiceDocument $document
      * @param InvoiceModel $model
      * @return Response
+     * @throws \Exception
      */
     public function render(InvoiceDocument $document, InvoiceModel $model): Response
     {

src/Invoice/Renderer/CsvRenderer.php

@@ -33,12 +33,16 @@ class CsvRenderer extends AbstractSpreadsheetRenderer implements RendererInterfa
 
     /**
      * @param Spreadsheet $spreadsheet
-     * @return bool|string
-     * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
+     * @return string
+     * @throws \Exception
      */
     protected function saveSpreadsheet(Spreadsheet $spreadsheet)
     {
         $filename = tempnam(sys_get_temp_dir(), 'kimai-invoice-csv');
+        if (false === $filename) {
+            throw new \Exception('Could not open temporary file');
+        }
+
         $writer = IOFactory::createWriter($spreadsheet, 'Csv');
         $writer->save($filename);
 

src/Invoice/Renderer/DocxRenderer.php

@@ -14,6 +14,7 @@ use App\Invoice\RendererInterface;
 use App\Model\InvoiceModel;
 use PhpOffice\PhpWord\Escaper\Xml;
 use PhpOffice\PhpWord\Exception\Exception as OfficeException;
+use PhpOffice\PhpWord\Settings;
 use PhpOffice\PhpWord\TemplateProcessor;
 use Symfony\Component\HttpFoundation\File\Stream;
 use Symfony\Component\HttpFoundation\Response;
@@ -27,7 +28,7 @@ class DocxRenderer extends AbstractRenderer implements RendererInterface
      */
     public function render(InvoiceDocument $document, InvoiceModel $model): Response
     {
-        \PhpOffice\PhpWord\Settings::setOutputEscapingEnabled(false);
+        Settings::setOutputEscapingEnabled(false);
 
         $filename = basename($document->getFilename());
 

src/Invoice/Renderer/OdsRenderer.php

@@ -33,12 +33,16 @@ class OdsRenderer extends AbstractSpreadsheetRenderer implements RendererInterfa
 
     /**
      * @param Spreadsheet $spreadsheet
-     * @return bool|string
-     * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
+     * @return string
+     * @throws \Exception
      */
     protected function saveSpreadsheet(Spreadsheet $spreadsheet)
     {
         $filename = tempnam(sys_get_temp_dir(), 'kimai-invoice-ods');
+        if (false === $filename) {
+            throw new \Exception('Could not open temporary file');
+        }
+
         $writer = IOFactory::createWriter($spreadsheet, 'Ods');
         $writer->save($filename);
 

src/Invoice/Renderer/RendererTrait.php

@@ -56,7 +56,8 @@ trait RendererTrait
     abstract protected function getFormattedTime(\DateTime $date);
 
     /**
-     * @param $amount
+     * @param int $amount
+     * @param string $currency
      * @return mixed
      */
     abstract protected function getFormattedMoney($amount, $currency);
@@ -68,7 +69,7 @@ trait RendererTrait
     abstract protected function getFormattedMonthName(\DateTime $date);
 
     /**
-     * @param $seconds
+     * @param int $seconds
      * @return mixed
      */
     abstract protected function getFormattedDuration($seconds);

src/Invoice/Renderer/XlsxRenderer.php

@@ -33,12 +33,16 @@ class XlsxRenderer extends AbstractSpreadsheetRenderer implements RendererInterf
 
     /**
      * @param Spreadsheet $spreadsheet
-     * @return bool|string
-     * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
+     * @return string
+     * @throws \Exception
      */
     protected function saveSpreadsheet(Spreadsheet $spreadsheet)
     {
         $filename = tempnam(sys_get_temp_dir(), 'kimai-invoice-xlsx');
+        if (false === $filename) {
+            throw new \Exception('Could not open temporary file');
+        }
+
         $writer = IOFactory::createWriter($spreadsheet, 'Xlsx');
         $writer->save($filename);