Release 2.12 (#4609)

tests/Model/Statistic/AbstractTimesheetTest.php

@@ -14,7 +14,7 @@ use PHPUnit\Framework\TestCase;
 
 abstract class AbstractTimesheetTest extends TestCase
 {
-    protected function assertDefaultValues(Timesheet $sut)
+    public function assertDefaultValues(Timesheet $sut): void
     {
         self::assertSame(0.0, $sut->getRate());
         self::assertSame(0, $sut->getDuration());
@@ -25,7 +25,7 @@ abstract class AbstractTimesheetTest extends TestCase
         self::assertSame(0.0, $sut->getTotalInternalRate());
     }
 
-    protected function assertSetter(Timesheet $sut)
+    public function assertSetter(Timesheet $sut): void
     {
         $sut->setTotalInternalRate(5485.84);
         $sut->setTotalRate(1234.23);

tests/Model/Statistic/BudgetStatisticTest.php

@@ -17,17 +17,17 @@ use App\Tests\Model\AbstractTimesheetCountedStatisticTest;
  */
 class BudgetStatisticTest extends AbstractTimesheetCountedStatisticTest
 {
-    public function testDefaultValues()
+    public function testDefaultValues(): void
     {
         $this->assertDefaultValues(new BudgetStatistic());
     }
 
-    public function testSetter()
+    public function testSetter(): void
     {
         $this->assertSetter(new BudgetStatistic());
     }
 
-    public function testJsonSerialize()
+    public function testJsonSerialize(): void
     {
         $this->assertJsonSerialize(new BudgetStatistic());
     }

tests/Model/Statistic/DayTest.php

@@ -17,21 +17,21 @@ use DateTime;
  */
 class DayTest extends AbstractTimesheetTest
 {
-    public function testDefaultValues()
+    public function testDefaultValues(): void
     {
         $date = new DateTime('-8 hours');
         $sut = new Day($date, 0, 0.0);
         $this->assertDefaultValues($sut);
     }
 
-    public function testSetter()
+    public function testSetter(): void
     {
         $date = new DateTime('-8 hours');
         $sut = new Day($date, 12340, 197.25956);
         $this->assertSetter($sut);
     }
 
-    public function testConstruct()
+    public function testConstruct(): void
     {
         $date = new DateTime('-8 hours');
         $sut = new Day($date, 12340, 197.25956);
@@ -43,7 +43,7 @@ class DayTest extends AbstractTimesheetTest
         self::assertSame(0, $sut->getTotalDurationBillable());
     }
 
-    public function testAllowedMonths()
+    public function testAllowedMonths(): void
     {
         $date = new DateTime('-8 hours');
         $sut = new Day($date, 12340, 197.25956);
@@ -57,7 +57,7 @@ class DayTest extends AbstractTimesheetTest
         self::assertSame(12345, $sut->getTotalDurationBillable());
     }
 
-    public function testSetDetails()
+    public function testSetDetails(): void
     {
         $sut = new Day(new DateTime(), 12340, 197.25956);
 

tests/Model/Statistic/MonthTest.php

@@ -17,7 +17,7 @@ use InvalidArgumentException;
  */
 class MonthTest extends AbstractTimesheetTest
 {
-    public function testDefaultValues()
+    public function testDefaultValues(): void
     {
         $sut = new Month('01');
         $this->assertDefaultValues($sut);
@@ -60,7 +60,7 @@ class MonthTest extends AbstractTimesheetTest
     /**
      * @dataProvider getTestData
      */
-    public function testAllowedMonths($init, $month, $number)
+    public function testAllowedMonths($init, $month, $number): void
     {
         $sut = new Month($init);
         self::assertEquals($month, $sut->getMonth());
@@ -79,14 +79,14 @@ class MonthTest extends AbstractTimesheetTest
     /**
      * @dataProvider getInvalidTestData
      */
-    public function testInvalidMonths($month)
+    public function testInvalidMonths($month): void
     {
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage('Invalid month given. Expected 1-12, received "' . ((int) $month) . '".');
         new Month($month);
     }
 
-    public function testSetter()
+    public function testSetter(): void
     {
         $sut = new Month('01');
         $this->assertSetter($sut);

tests/Model/Statistic/StatisticDateTest.php

@@ -17,7 +17,7 @@ use DateTime;
  */
 class StatisticDateTest extends AbstractTimesheetTest
 {
-    public function testDefaultValues()
+    public function testDefaultValues(): void
     {
         $dateTime = new \DateTime('-8 hours');
         $sut = new StatisticDate($dateTime);
@@ -28,14 +28,14 @@ class StatisticDateTest extends AbstractTimesheetTest
         self::assertEquals($dateTime->getTimestamp(), $sut->getDate()->getTimestamp());
     }
 
-    public function testSetter()
+    public function testSetter(): void
     {
         $date = new DateTime('-8 hours');
         $sut = new StatisticDate($date);
         $this->assertSetter($sut);
     }
 
-    public function testAdditionalMethods()
+    public function testAdditionalMethods(): void
     {
         $date = new DateTime('-8 hours');
         $sut = new StatisticDate($date);

tests/Model/Statistic/TimesheetTest.php

@@ -16,13 +16,13 @@ use App\Model\Statistic\Timesheet;
  */
 class TimesheetTest extends AbstractTimesheetTest
 {
-    public function testDefaultValues()
+    public function testDefaultValues(): void
     {
         $sut = new Timesheet();
         $this->assertDefaultValues($sut);
     }
 
-    public function testSetter()
+    public function testSetter(): void
     {
         $sut = new Timesheet();
         $this->assertSetter($sut);