Release 2.12 (#4609)

tests/Timesheet/TrackingMode/AbstractTrackingModeTest.php

@@ -33,12 +33,12 @@ abstract class AbstractTrackingModeTest extends TestCase
         return $timesheet;
     }
 
-    protected function assertDefaultBegin(Timesheet $timesheet)
+    public function assertDefaultBegin(Timesheet $timesheet): void
     {
         self::assertNull($timesheet->getBegin());
     }
 
-    public function testCreateDoesNotChangeAnythingOnEmptyRequest()
+    public function testCreateDoesNotChangeAnythingOnEmptyRequest(): void
     {
         $sut = $this->createSut();
 
@@ -53,7 +53,7 @@ abstract class AbstractTrackingModeTest extends TestCase
         self::assertNull($timesheet->getEnd());
     }
 
-    public function testCreateUseBeginWithoutEndDateFromRequest()
+    public function testCreateUseBeginWithoutEndDateFromRequest(): void
     {
         $sut = $this->createSut();
 
@@ -70,7 +70,7 @@ abstract class AbstractTrackingModeTest extends TestCase
         self::assertEquals(0, $timesheet->getDuration());
     }
 
-    public function testCreateUseBeginEndDateFromRequest()
+    public function testCreateUseBeginEndDateFromRequest(): void
     {
         $sut = $this->createSut();
 
@@ -90,7 +90,7 @@ abstract class AbstractTrackingModeTest extends TestCase
         self::assertEquals(28800, $timesheet->getDuration());
     }
 
-    public function testCreateIgnoresValidEndOnInvalidBeginDateFromRequest()
+    public function testCreateIgnoresValidEndOnInvalidBeginDateFromRequest(): void
     {
         $sut = $this->createSut();
 
@@ -107,7 +107,7 @@ abstract class AbstractTrackingModeTest extends TestCase
         self::assertEquals(0, $timesheet->getDuration());
     }
 
-    public function testCreateUsesBeginAndIgnoresInvalidEndDateFromRequest()
+    public function testCreateUsesBeginAndIgnoresInvalidEndDateFromRequest(): void
     {
         $sut = $this->createSut();
 
@@ -125,7 +125,7 @@ abstract class AbstractTrackingModeTest extends TestCase
         self::assertEquals(0, $timesheet->getDuration());
     }
 
-    public function testCreateUseFromWithoutToDatetimeFromRequest()
+    public function testCreateUseFromWithoutToDatetimeFromRequest(): void
     {
         $sut = $this->createSut();
 
@@ -141,7 +141,7 @@ abstract class AbstractTrackingModeTest extends TestCase
         self::assertEquals(0, $timesheet->getDuration());
     }
 
-    public function testCreateUseFromToDatetimeFromRequest()
+    public function testCreateUseFromToDatetimeFromRequest(): void
     {
         $sut = $this->createSut();
 
@@ -161,7 +161,7 @@ abstract class AbstractTrackingModeTest extends TestCase
         self::assertEquals(12196, $timesheet->getDuration());
     }
 
-    public function testCreateUseFromToDatetimeOverwritesBeginEndTatesFromRequest()
+    public function testCreateUseFromToDatetimeOverwritesBeginEndTatesFromRequest(): void
     {
         $sut = $this->createSut();
 
@@ -183,7 +183,7 @@ abstract class AbstractTrackingModeTest extends TestCase
         self::assertEquals(12196, $timesheet->getDuration());
     }
 
-    public function testCreateIgnoresValidToOnInvalidFromDatetimeFromRequest()
+    public function testCreateIgnoresValidToOnInvalidFromDatetimeFromRequest(): void
     {
         $sut = $this->createSut();
 
@@ -200,7 +200,7 @@ abstract class AbstractTrackingModeTest extends TestCase
         self::assertEquals(0, $timesheet->getDuration());
     }
 
-    public function testCreateUsesFromAndIgnoresInvalidToDatetimeFromRequest()
+    public function testCreateUsesFromAndIgnoresInvalidToDatetimeFromRequest(): void
     {
         $sut = $this->createSut();
 

tests/Timesheet/TrackingMode/DefaultModeTest.php

@@ -18,7 +18,7 @@ use App\Timesheet\TrackingMode\DefaultMode;
  */
 class DefaultModeTest extends AbstractTrackingModeTest
 {
-    protected function assertDefaultBegin(Timesheet $timesheet)
+    public function assertDefaultBegin(Timesheet $timesheet): void
     {
         self::assertNotNull($timesheet->getBegin());
         self::assertInstanceOf(\DateTime::class, $timesheet->getBegin());
@@ -32,7 +32,7 @@ class DefaultModeTest extends AbstractTrackingModeTest
         return new DefaultMode((new RoundingServiceFactory($this))->create());
     }
 
-    public function testDefaultValues()
+    public function testDefaultValues(): void
     {
         $sut = $this->createSut();
 

tests/Timesheet/TrackingMode/DurationFixedBeginModeTest.php

@@ -30,7 +30,7 @@ class DurationFixedBeginModeTest extends TestCase
         return new DurationFixedBeginMode($configuration);
     }
 
-    public function testDefaultValues()
+    public function testDefaultValues(): void
     {
         $sut = $this->createSut();
 
@@ -42,7 +42,7 @@ class DurationFixedBeginModeTest extends TestCase
         self::assertEquals('duration_fixed_begin', $sut->getId());
     }
 
-    public function testNow()
+    public function testNow(): void
     {
         $seconds = (new \DateTime())->getTimestamp();
         $timesheet = new Timesheet();
@@ -54,7 +54,7 @@ class DurationFixedBeginModeTest extends TestCase
         self::assertLessThanOrEqual(2, $diff);
     }
 
-    public function testCreate()
+    public function testCreate(): void
     {
         $timesheet = new Timesheet();
         $timesheet->setBegin(new \DateTime('22:54'));
@@ -66,7 +66,7 @@ class DurationFixedBeginModeTest extends TestCase
         self::assertEquals('13:47', $timesheet->getBegin()->format('H:i'));
     }
 
-    public function testCreateWithoutBeginInjectsBegin()
+    public function testCreateWithoutBeginInjectsBegin(): void
     {
         $timesheet = (new Timesheet())->setUser(new User());
         $request = new Request();

tests/Timesheet/TrackingMode/PunchInOutModeTest.php

@@ -20,7 +20,7 @@ use Symfony\Component\HttpFoundation\Request;
  */
 class PunchInOutModeTest extends TestCase
 {
-    public function testDefaultValues()
+    public function testDefaultValues(): void
     {
         $sut = new PunchInOutMode();
 
@@ -32,7 +32,7 @@ class PunchInOutModeTest extends TestCase
         self::assertEquals('punch', $sut->getId());
     }
 
-    public function testCreate()
+    public function testCreate(): void
     {
         $startingTime = new \DateTime('22:54');
         $timesheet = new Timesheet();
@@ -44,7 +44,7 @@ class PunchInOutModeTest extends TestCase
         self::assertEquals($timesheet->getBegin(), $startingTime);
     }
 
-    public function testCreateWithoutBegin()
+    public function testCreateWithoutBegin(): void
     {
         $timesheet = (new Timesheet())->setUser(new User());
         $request = new Request();