upgraded to symfony 4 #74 (#81)

src/Voter/AbstractVoter.php

@@ -0,0 +1,52 @@
+<?php
+
+/*
+ * This file is part of the Kimai package.
+ *
+ * (c) Kevin Papst <kevin@kevinpapst.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Voter;
+
+use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
+use Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface;
+use Symfony\Component\Security\Core\Authorization\Voter\Voter;
+
+/**
+ * Abstract voter to help with checking user roles.
+ *
+ * @author Kevin Papst <kevin@kevinpapst.de>
+ */
+abstract class AbstractVoter extends Voter
+{
+    /**
+     * @var AccessDecisionManagerInterface
+     */
+    protected $decisionManager;
+
+    /**
+     * AbstractVoter constructor.
+     * @param AccessDecisionManagerInterface $decisionManager
+     */
+    public function __construct(AccessDecisionManagerInterface $decisionManager)
+    {
+        $this->decisionManager = $decisionManager;
+    }
+
+    /**
+     * @param string $role
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function hasRole($role, TokenInterface $token)
+    {
+        if ($this->decisionManager->decide($token, array($role))) {
+            return true;
+        }
+
+        return false;
+    }
+}

src/Voter/ActivityVoter.php

@@ -0,0 +1,112 @@
+<?php
+
+/*
+ * This file is part of the Kimai package.
+ *
+ * (c) Kevin Papst <kevin@kevinpapst.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Voter;
+
+use App\Entity\User;
+use App\Voter\AbstractVoter;
+use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
+use App\Entity\Activity;
+
+/**
+ * A voter to check permissions on Activities.
+ *
+ * @author Kevin Papst <kevin@kevinpapst.de>
+ */
+class ActivityVoter extends AbstractVoter
+{
+    const VIEW = 'view';
+    const EDIT = 'edit';
+    const DELETE = 'delete';
+
+    /**
+     * @param string $attribute
+     * @param mixed $subject
+     * @return bool
+     */
+    protected function supports($attribute, $subject)
+    {
+            if (!in_array($attribute, array(self::VIEW, self::EDIT, self::DELETE))) {
+            return false;
+        }
+
+        if (!$subject instanceof Activity) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * @param string $attribute
+     * @param Activity $subject
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
+    {
+        $user = $token->getUser();
+
+        if (!$user instanceof User) {
+            return false;
+        }
+
+        switch ($attribute) {
+            case self::VIEW:
+                return $this->canView($subject, $user, $token);
+            case self::EDIT:
+                return $this->canEdit($subject, $user, $token);
+            case self::DELETE:
+                return $this->canDelete($token);
+        }
+
+        return false;
+    }
+
+    /**
+     * @param Activity $activity
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canView(Activity $activity, User $user, TokenInterface $token)
+    {
+        if ($this->canEdit($activity, $user, $token)) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * @param Activity $activity
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canEdit(Activity $activity, User $user, TokenInterface $token)
+    {
+        if ($this->canDelete($token)) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canDelete(TokenInterface $token)
+    {
+        return $this->hasRole('ROLE_ADMIN', $token);
+    }
+}

src/Voter/CustomerVoter.php

@@ -0,0 +1,112 @@
+<?php
+
+/*
+ * This file is part of the Kimai package.
+ *
+ * (c) Kevin Papst <kevin@kevinpapst.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Voter;
+
+use App\Entity\User;
+use App\Voter\AbstractVoter;
+use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
+use App\Entity\Customer;
+
+/**
+ * A voter to check permissions on Customers.
+ *
+ * @author Kevin Papst <kevin@kevinpapst.de>
+ */
+class CustomerVoter extends AbstractVoter
+{
+    const VIEW = 'view';
+    const EDIT = 'edit';
+    const DELETE = 'delete';
+
+    /**
+     * @param string $attribute
+     * @param mixed $subject
+     * @return bool
+     */
+    protected function supports($attribute, $subject)
+    {
+        if (!in_array($attribute, array(self::VIEW, self::EDIT, self::DELETE))) {
+            return false;
+        }
+
+        if (!$subject instanceof Customer) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * @param string $attribute
+     * @param Customer $subject
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
+    {
+        $user = $token->getUser();
+
+        if (!$user instanceof User) {
+            return false;
+        }
+
+        switch ($attribute) {
+            case self::VIEW:
+                return $this->canView($subject, $user, $token);
+            case self::EDIT:
+                return $this->canEdit($subject, $user, $token);
+            case self::DELETE:
+                return $this->canDelete($token);
+        }
+
+        return false;
+    }
+
+    /**
+     * @param Customer $customer
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canView(Customer $customer, User $user, TokenInterface $token)
+    {
+        if ($this->canEdit($customer, $user, $token)) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * @param Customer $customer
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canEdit(Customer $customer, User $user, TokenInterface $token)
+    {
+        if ($this->canDelete($token)) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canDelete(TokenInterface $token)
+    {
+        return $this->hasRole('ROLE_ADMIN', $token);
+    }
+}

src/Voter/ProjectVoter.php

@@ -0,0 +1,112 @@
+<?php
+
+/*
+ * This file is part of the Kimai package.
+ *
+ * (c) Kevin Papst <kevin@kevinpapst.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Voter;
+
+use App\Entity\User;
+use App\Voter\AbstractVoter;
+use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
+use App\Entity\Project;
+
+/**
+ * A voter to check permissions on Projects.
+ *
+ * @author Kevin Papst <kevin@kevinpapst.de>
+ */
+class ProjectVoter extends AbstractVoter
+{
+    const VIEW = 'view';
+    const EDIT = 'edit';
+    const DELETE = 'delete';
+
+    /**
+     * @param string $attribute
+     * @param mixed $subject
+     * @return bool
+     */
+    protected function supports($attribute, $subject)
+    {
+        if (!in_array($attribute, array(self::VIEW, self::EDIT, self::DELETE))) {
+            return false;
+        }
+
+        if (!$subject instanceof Project) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * @param string $attribute
+     * @param Project $subject
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
+    {
+        $user = $token->getUser();
+
+        if (!$user instanceof User) {
+            return false;
+        }
+
+        switch ($attribute) {
+            case self::VIEW:
+                return $this->canView($subject, $user, $token);
+            case self::EDIT:
+                return $this->canEdit($subject, $user, $token);
+            case self::DELETE:
+                return $this->canDelete($token);
+        }
+
+        return false;
+    }
+
+    /**
+     * @param Project $project
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canView(Project $project, User $user, TokenInterface $token)
+    {
+        if ($this->canEdit($project, $user, $token)) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * @param Project $project
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canEdit(Project $project, User $user, TokenInterface $token)
+    {
+        if ($this->canDelete($token)) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canDelete(TokenInterface $token)
+    {
+        return $this->hasRole('ROLE_ADMIN', $token);
+    }
+}

src/Voter/TimesheetVoter.php

@@ -0,0 +1,177 @@
+<?php
+
+/*
+ * This file is part of the Kimai package.
+ *
+ * (c) Kevin Papst <kevin@kevinpapst.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Voter;
+
+use App\Entity\User;
+use App\Voter\AbstractVoter;
+use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
+use App\Entity\Activity;
+use App\Entity\Timesheet;
+
+/**
+ * A voter to check permissions on Timesheets.
+ *
+ * @author Kevin Papst <kevin@kevinpapst.de>
+ */
+class TimesheetVoter extends AbstractVoter
+{
+    const START = 'start';
+    const STOP = 'stop';
+    const VIEW = 'view';
+    const EDIT = 'edit';
+    const DELETE = 'delete';
+
+    /**
+     * @param string $attribute
+     * @param mixed $subject
+     * @return bool
+     */
+    protected function supports($attribute, $subject)
+    {
+        if (!in_array($attribute, array(self::START, self::STOP, self::VIEW, self::EDIT, self::DELETE))) {
+            return false;
+        }
+
+        if ($subject instanceof Activity && $attribute == self::START) {
+            return true;
+        }
+
+        if (!$subject instanceof Timesheet) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * @param string $attribute
+     * @param Timesheet]Activity $subject
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
+    {
+        $user = $token->getUser();
+
+        if (!$user instanceof User) {
+            return false;
+        }
+
+        switch ($attribute) {
+            case self::STOP:
+                return $this->canStop($subject, $user, $token);
+            case self::START:
+                return $this->canStart($subject, $user, $token);
+            case self::VIEW:
+                return $this->canView($subject, $user, $token);
+            case self::EDIT:
+                return $this->canEdit($subject, $user, $token);
+            case self::DELETE:
+                return $this->canDelete($subject, $user, $token);
+        }
+
+        return false;
+    }
+
+    /**
+     * @param Timesheet $timesheet
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canStop(Timesheet $timesheet, User $user, TokenInterface $token)
+    {
+        // if a teamlead stops an entry for another user, check that this user is part of his team
+        return $this->isOwnOrTeamlead($timesheet, $user, $token);
+    }
+
+    /**
+     * @param Activity $activity
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canStart(Activity $activity, User $user, TokenInterface $token)
+    {
+        // we could check the amount of active entries
+        // if a teamlead starts an entry for another user, check that this user is part of his team
+
+        if (!$activity->getVisible()) {
+            return false;
+        }
+        if (!$activity->getProject()->getVisible()) {
+            return false;
+        }
+        if (!$activity->getProject()->getCustomer()->getVisible()) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * @param Timesheet $timesheet
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canView(Timesheet $timesheet, User $user, TokenInterface $token)
+    {
+        return $this->isOwnOrTeamlead($timesheet, $user, $token);
+    }
+
+    /**
+     * @param Timesheet $timesheet
+     * @param User $user
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canEdit(Timesheet $timesheet, User $user, TokenInterface $token)
+    {
+        return $this->isOwnOrTeamlead($timesheet, $user, $token);
+    }
+
+    /**
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canDelete(Timesheet $timesheet, User $user, TokenInterface $token)
+    {
+        return $this->isOwnOrAdmin($timesheet, $user, $token);
+    }
+
+    /**
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function isOwnOrTeamlead(Timesheet $timesheet, User $user, TokenInterface $token)
+    {
+        if ($timesheet->getUser()->getId() == $user->getId()) {
+            return true;
+        }
+
+        return $this->hasRole('ROLE_TEAMLEAD', $token);
+    }
+
+    /**
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function isOwnOrAdmin(Timesheet $timesheet, User $user, TokenInterface $token)
+    {
+        if ($timesheet->getUser()->getId() == $user->getId()) {
+            return true;
+        }
+
+        return $this->hasRole('ROLE_ADMIN', $token);
+    }
+}

src/Voter/UserVoter.php

@@ -0,0 +1,130 @@
+<?php
+
+/*
+ * This file is part of the Kimai package.
+ *
+ * (c) Kevin Papst <kevin@kevinpapst.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Voter;
+
+use App\Entity\User;
+use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
+
+/**
+ * A voter to check permissions on user profiles.
+ *
+ * @author Kevin Papst <kevin@kevinpapst.de>
+ */
+class UserVoter extends AbstractVoter
+{
+    const VIEW = 'view';
+    const EDIT = 'edit';
+    const CREATE = 'create';
+    const DELETE = 'delete';
+    const PASSWORD = 'password';
+    const ROLES = 'roles';
+    const VIEW_ALL = 'view_all';
+
+    /**
+     * @param string $attribute
+     * @param mixed $subject
+     * @return bool
+     */
+    protected function supports($attribute, $subject)
+    {
+        if (!in_array(
+            $attribute,
+            [self::VIEW, self::VIEW_ALL, self::EDIT, self::CREATE, self::ROLES, self::PASSWORD, self::DELETE]
+        )) {
+            return false;
+        }
+
+        if (!$subject instanceof User) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * @param string $attribute
+     * @param User $subject
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
+    {
+        $user = $token->getUser();
+
+        if (!$user instanceof User) {
+            return false;
+        }
+
+        switch ($attribute) {
+            case self::VIEW:
+                return $this->canView($subject, $user, $token);
+            case self::EDIT:
+            case self::PASSWORD:
+                return $this->canEdit($subject, $user, $token);
+            case self::DELETE:
+                return $this->canDelete($subject, $user, $token);
+            case self::VIEW_ALL:
+            case self::CREATE: // create actually passes in the current user as $subject, not the new one
+            case self::ROLES:
+                return $this->canAdminUsers($token);
+        }
+
+        return false;
+    }
+
+    /**
+     * @param User $profile
+     * @param User $user
+     * @return bool
+     */
+    protected function canView(User $profile, User $user, TokenInterface $token)
+    {
+        if ($this->canEdit($profile, $user, $token)) {
+            return true;
+        }
+
+        return $profile->getId() == $user->getId();
+    }
+
+    /**
+     * @param User $profile
+     * @param User $user
+     * @return bool
+     */
+    protected function canEdit(User $profile, User $user, TokenInterface $token)
+    {
+        if ($this->canAdminUsers($token)) {
+            return true;
+        }
+
+        return $profile->getId() == $user->getId();
+    }
+
+    /**
+     * @param User $profile
+     * @param User $user
+     * @return bool
+     */
+    protected function canDelete(User $profile, User $user, TokenInterface $token)
+    {
+        return false;
+    }
+
+    /**
+     * @param TokenInterface $token
+     * @return bool
+     */
+    protected function canAdminUsers(TokenInterface $token)
+    {
+        return $this->hasRole('ROLE_SUPER_ADMIN', $token);
+    }
+}