jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

decrease minimum username length to 3 character (#362)

Browse Source
This commit is contained in:
Kevin Papst
2018-10-19 16:50:03 +02:00
committed by GitHub
parent ad171e7706
commit b46e752d0a
5 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/Command/CreateUserCommandTest.php
View File

@@ -14,8 +14,6 @@ use App\Entity\User;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\Console\Tester\CommandTester;
use Symfony\Component\Validator\ConstraintViolationListInterface;
use Symfony\Component\Validator\Validator\ValidatorInterface;
/**
* @coversDefaultClass \App\Command\CreateUserCommand
@@ -36,15 +34,10 @@ class CreateUserCommandTest extends KernelTestCase
$passwordEncoder = $container->get('security.password_encoder');
$validationResult = $this->getMockBuilder(ConstraintViolationListInterface::class)->getMock();
$validationResult->method('count')->willReturn(0);
$validator = $this->getMockBuilder(ValidatorInterface::class)->getMock();
$validator->method('validate')->willReturn($validationResult);
$this->application->add(new CreateUserCommand(
$passwordEncoder,
$container->get('doctrine'),
$validator
$container->get('validator')
));
}
@@ -75,6 +68,14 @@ class CreateUserCommandTest extends KernelTestCase
return $commandTester;
}
public function testUserWithValidationProblem()
{
$commandTester = $this->createUser('xx', '', 'ROLE_USER', '');
$output = $commandTester->getDisplay();
$this->assertContains('[ERROR] plainPassword ()', $output);
// TODO the test validator is misconfigured, doesn't find "short username" and "empty email"
}
public function testUserAlreadyExisting()
{
$this->createUser('MyTestUser', 'user@example.com', 'ROLE_USER', 'foobar');

2
tests/Controller/Admin/UserControllerTest.php
View File

@@ -126,7 +126,7 @@ class UserControllerTest extends ControllerBaseTest
[
[
'user_create' => [
'username' => 'Test',
'username' => 'xx',
'plainPassword' => ['first' => 'sdfsdf', 'second' => 'sdfxxx'],
'alias' => 'ycvyxcb',
'title' => '34rtwrtewrt',

4
tests/Entity/UserTest.php
View File

@@ -22,7 +22,7 @@ class UserTest extends AbstractEntityTest
return [
['', ''],
[null, null],
['test', 'test@'], // too short username
['xx', 'test@'], // too short username
[str_pad('#', 61, '-'), 'test@x.'], // too long username
[str_pad('#', 61, '-'), 'test@x.', ['xxxxx']], // too short password and invalid role
];
@@ -51,7 +51,7 @@ class UserTest extends AbstractEntityTest
public function getValidTestData()
{
return [
[str_pad('#', 6, '-'), 'test@x.x'], // shortest possible username
[str_pad('#', 3, '-'), 'test@x.x'], // shortest possible username
[str_pad('#', 60, '-'), 'test@x.x', ['ROLE_CUSTOMER']], // longest possible password and valid role
];
}