add user preference: default report (#2430)

tests/EventSubscriber/UserPreferenceSubscriberTest.php

@@ -23,6 +23,23 @@ use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
  */
 class UserPreferenceSubscriberTest extends TestCase
 {
+    public const EXPECTED_PREFERENCES = [
+        'hourly_rate',
+        'internal_rate',
+        'timezone',
+        'language',
+        'first_weekday',
+        'skin',
+        'theme.layout',
+        'theme.collapsed_sidebar',
+        'theme.update_browser_title',
+        'calendar.initial_view',
+         'reporting.initial_view',
+         'login.initial_view',
+         'timesheet.daily_stats',
+         'timesheet.export_decimal',
+    ];
+
     public function testGetSubscribedEvents()
     {
         $events = UserPreferenceSubscriber::getSubscribedEvents();
@@ -40,7 +57,11 @@ class UserPreferenceSubscriberTest extends TestCase
         self::assertSame($user, $event->getUser());
 
         $prefs = $sut->getDefaultPreferences($user);
-        self::assertCount(13, $prefs);
+        foreach ($prefs as $pref) {
+            $this->assertTrue(\in_array($pref->getName(), self::EXPECTED_PREFERENCES), 'Unknown user preference: ' . $pref->getName());
+        }
+
+        self::assertCount(\count(self::EXPECTED_PREFERENCES), $prefs);
 
         foreach ($prefs as $pref) {
             switch ($pref->getName()) {
@@ -70,7 +91,7 @@ class UserPreferenceSubscriberTest extends TestCase
         // TODO test merging values
         $sut->loadUserPreferences($event);
         $prefs = $event->getUser()->getPreferences();
-        self::assertCount(13, $prefs);
+        self::assertCount(\count(self::EXPECTED_PREFERENCES), $prefs);
 
         foreach ($prefs as $pref) {
             switch ($pref->getName()) {

tests/Reporting/ReportingServiceTest.php

@@ -24,7 +24,7 @@ class ReportingServiceTest extends TestCase
     protected function getSut(bool $isGranted = false): ReportingService
     {
         $dispatcher = $this->createMock(EventDispatcherInterface::class);
-        $dispatcher->expects($this->once())->method('dispatch')->willReturnCallback(function ($event) {
+        $dispatcher->expects($this->exactly($isGranted ? 1 : 0))->method('dispatch')->willReturnCallback(function ($event) {
             $this->assertInstanceOf(ReportingEvent::class, $event);
         });