jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Upgrade tests to PhpUnit 10 (#5252)

Browse Source
This commit is contained in:
Kevin Papst
2024-12-22 01:25:30 +01:00
committed by GitHub
parent 9bd37fb695
commit c7f0508707
377 changed files with 3308 additions and 3409 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Entity/AbstractCommentEntityTest.php → tests/Entity/AbstractCommentEntityTestCase.php
View File

@@ -13,7 +13,7 @@ use App\Entity\CommentInterface;
use App\Entity\User;
use PHPUnit\Framework\TestCase;
abstract class AbstractCommentEntityTest extends TestCase
abstract class AbstractCommentEntityTestCase extends TestCase
{
abstract protected function getEntity(): CommentInterface;

18
tests/Entity/AbstractEntityTest.php → tests/Entity/AbstractEntityTestCase.php
View File

@@ -12,31 +12,31 @@ namespace App\Tests\Entity;
use App\Entity\EntityWithBudget;
use PHPUnit\Framework\TestCase;
abstract class AbstractEntityTest extends TestCase
abstract class AbstractEntityTestCase extends TestCase
{
public function assertBudget(EntityWithBudget $entityWithBudget): void
{
$this->assertEquals(0.0, $entityWithBudget->getBudget());
$this->assertEquals(0, $entityWithBudget->getTimeBudget());
$this->assertNull($entityWithBudget->getBudgetType());
$this->assertFalse($entityWithBudget->isMonthlyBudget());
self::assertEquals(0.0, $entityWithBudget->getBudget());
self::assertEquals(0, $entityWithBudget->getTimeBudget());
self::assertNull($entityWithBudget->getBudgetType());
self::assertFalse($entityWithBudget->isMonthlyBudget());
self::assertFalse($entityWithBudget->hasBudget());
self::assertFalse($entityWithBudget->hasTimeBudget());
$entityWithBudget->setBudget(12345.67);
$this->assertEquals(12345.67, $entityWithBudget->getBudget());
self::assertEquals(12345.67, $entityWithBudget->getBudget());
self::assertTrue($entityWithBudget->hasBudget());
self::assertFalse($entityWithBudget->hasTimeBudget());
$entityWithBudget->setTimeBudget(937321);
$this->assertEquals(937321, $entityWithBudget->getTimeBudget());
self::assertEquals(937321, $entityWithBudget->getTimeBudget());
self::assertTrue($entityWithBudget->hasTimeBudget());
$entityWithBudget->setBudgetType('month');
$this->assertTrue($entityWithBudget->isMonthlyBudget());
self::assertTrue($entityWithBudget->isMonthlyBudget());
$entityWithBudget->setBudgetType(null);
$this->assertFalse($entityWithBudget->isMonthlyBudget());
self::assertFalse($entityWithBudget->isMonthlyBudget());
try {
$entityWithBudget->setBudgetType('foo');

2
tests/Entity/AbstractMetaEntityTest.php → tests/Entity/AbstractMetaEntityTestCase.php
View File

@@ -17,7 +17,7 @@ use Symfony\Component\Validator\Constraints\Length;
use Symfony\Component\Validator\Constraints\NotBlank;
use Symfony\Component\Validator\Constraints\NotNull;
abstract class AbstractMetaEntityTest extends TestCase
abstract class AbstractMetaEntityTestCase extends TestCase
{
abstract protected function getEntity(): EntityWithMetaFields;

24
tests/Entity/AccessTokenTest.php
View File

@@ -15,31 +15,31 @@ use App\Entity\User;
/**
* @covers \App\Entity\AccessToken
*/
class AccessTokenTest extends AbstractEntityTest
class AccessTokenTest extends AbstractEntityTestCase
{
public function testDefaultValues(): void
{
$user = new User();
$sut = new AccessToken($user, 'foo');
$this->assertNull($sut->getId());
$this->assertNull($sut->getName());
$this->assertNull($sut->getExpiresAt());
$this->assertNull($sut->getLastUsage());
$this->assertSame('foo', $sut->getToken());
$this->assertSame($user, $sut->getUser());
$this->assertTrue($sut->isValid());
self::assertNull($sut->getId());
self::assertNull($sut->getName());
self::assertNull($sut->getExpiresAt());
self::assertNull($sut->getLastUsage());
self::assertSame('foo', $sut->getToken());
self::assertSame($user, $sut->getUser());
self::assertTrue($sut->isValid());
$sut->setName('bar');
$this->assertSame('bar', $sut->getName());
self::assertSame('bar', $sut->getName());
$dateTime = new \DateTimeImmutable('-1 year');
$sut->setLastUsage($dateTime);
$this->assertSame($dateTime, $sut->getLastUsage());
self::assertSame($dateTime, $sut->getLastUsage());
$dateTime = new \DateTimeImmutable('-1 month');
$sut->setExpiresAt($dateTime);
$this->assertSame($dateTime, $sut->getExpiresAt());
self::assertSame($dateTime, $sut->getExpiresAt());
}
public function testIsValid(): void
@@ -47,6 +47,6 @@ class AccessTokenTest extends AbstractEntityTest
$user = new User();
$sut = new AccessToken($user, 'foo');
$sut->setExpiresAt(new \DateTimeImmutable('-1 day'));
$this->assertFalse($sut->isValid());
self::assertFalse($sut->isValid());
}
}

2
tests/Entity/ActivityMetaTest.php
View File

@@ -18,7 +18,7 @@ use App\Entity\Timesheet;
/**
* @covers \App\Entity\ActivityMeta
*/
class ActivityMetaTest extends AbstractMetaEntityTest
class ActivityMetaTest extends AbstractMetaEntityTestCase
{
protected function getEntity(): EntityWithMetaFields
{

56
tests/Entity/ActivityTest.php
View File

@@ -21,25 +21,25 @@ use Doctrine\Common\Collections\Collection;
/**
* @covers \App\Entity\Activity
*/
class ActivityTest extends AbstractEntityTest
class ActivityTest extends AbstractEntityTestCase
{
public function testDefaultValues(): void
{
$sut = new Activity();
$this->assertNull($sut->getId());
$this->assertNull($sut->getProject());
$this->assertNull($sut->getName());
$this->assertNull($sut->getComment());
$this->assertNull($sut->getInvoiceText());
$this->assertTrue($sut->isVisible());
$this->assertTrue($sut->isBillable());
$this->assertTrue($sut->isGlobal());
$this->assertNull($sut->getColor());
self::assertNull($sut->getId());
self::assertNull($sut->getProject());
self::assertNull($sut->getName());
self::assertNull($sut->getComment());
self::assertNull($sut->getInvoiceText());
self::assertTrue($sut->isVisible());
self::assertTrue($sut->isBillable());
self::assertTrue($sut->isGlobal());
self::assertNull($sut->getColor());
self::assertFalse($sut->hasColor());
$this->assertInstanceOf(Collection::class, $sut->getMetaFields());
$this->assertEquals(0, $sut->getMetaFields()->count());
$this->assertNull($sut->getMetaField('foo'));
$this->assertInstanceOf(Collection::class, $sut->getTeams());
self::assertInstanceOf(Collection::class, $sut->getMetaFields());
self::assertEquals(0, $sut->getMetaFields()->count());
self::assertNull($sut->getMetaField('foo'));
self::assertInstanceOf(Collection::class, $sut->getTeams());
}
public function testBudgets(): void
@@ -50,36 +50,36 @@ class ActivityTest extends AbstractEntityTest
public function testSetterAndGetter(): void
{
$sut = new Activity();
$this->assertInstanceOf(Activity::class, $sut->setName('foo-bar'));
$this->assertEquals('foo-bar', $sut->getName());
$this->assertEquals('foo-bar', (string) $sut);
self::assertInstanceOf(Activity::class, $sut->setName('foo-bar'));
self::assertEquals('foo-bar', $sut->getName());
self::assertEquals('foo-bar', (string) $sut);
$this->assertInstanceOf(Activity::class, $sut->setVisible(false));
$this->assertFalse($sut->isVisible());
self::assertInstanceOf(Activity::class, $sut->setVisible(false));
self::assertFalse($sut->isVisible());
$sut->setVisible(false);
self::assertFalse($sut->isVisible());
$sut->setVisible(true);
self::assertTrue($sut->isVisible());
$this->assertInstanceOf(Activity::class, $sut->setComment('hello world'));
$this->assertEquals('hello world', $sut->getComment());
self::assertInstanceOf(Activity::class, $sut->setComment('hello world'));
self::assertEquals('hello world', $sut->getComment());
$sut->setInvoiceText('very long invoice text comment 12324');
self::assertEquals('very long invoice text comment 12324', $sut->getInvoiceText());
self::assertFalse($sut->hasColor());
$sut->setColor('#fffccc');
$this->assertEquals('#fffccc', $sut->getColor());
self::assertEquals('#fffccc', $sut->getColor());
self::assertTrue($sut->hasColor());
$sut->setColor(Constants::DEFAULT_COLOR);
$this->assertNull($sut->getColor());
self::assertNull($sut->getColor());
self::assertFalse($sut->hasColor());
$this->assertTrue($sut->isGlobal());
$this->assertInstanceOf(Activity::class, $sut->setProject(new Project()));
$this->assertFalse($sut->isGlobal());
self::assertTrue($sut->isGlobal());
self::assertInstanceOf(Activity::class, $sut->setProject(new Project()));
self::assertFalse($sut->isGlobal());
}
public function testMetaFields(): void
@@ -87,7 +87,7 @@ class ActivityTest extends AbstractEntityTest
$sut = new Activity();
$meta = new ActivityMeta();
$meta->setName('foo')->setValue('bar2')->setType('test');
$this->assertInstanceOf(Activity::class, $sut->setMetaField($meta));
self::assertInstanceOf(Activity::class, $sut->setMetaField($meta));
self::assertEquals(1, $sut->getMetaFields()->count());
$result = $sut->getMetaField('foo');
self::assertSame($result, $meta);
@@ -96,7 +96,7 @@ class ActivityTest extends AbstractEntityTest
$meta2 = new ActivityMeta();
$meta2->setName('foo')->setValue('bar')->setType('test2');
$this->assertInstanceOf(Activity::class, $sut->setMetaField($meta2));
self::assertInstanceOf(Activity::class, $sut->setMetaField($meta2));
self::assertEquals(1, $sut->getMetaFields()->count());
self::assertCount(0, $sut->getVisibleMetaFields());

24
tests/Entity/BookmarkTest.php
View File

@@ -21,32 +21,32 @@ class BookmarkTest extends TestCase
public function testDefaultValues(): void
{
$sut = new Bookmark();
$this->assertNull($sut->getId());
$this->assertNull($sut->getName());
$this->assertIsArray($sut->getContent());
$this->assertEquals([], $sut->getContent());
$this->assertNull($sut->getType());
$this->assertNull($sut->getUser());
self::assertNull($sut->getId());
self::assertNull($sut->getName());
self::assertIsArray($sut->getContent());
self::assertEquals([], $sut->getContent());
self::assertNull($sut->getType());
self::assertNull($sut->getUser());
}
public function testSetterAndGetter(): void
{
$sut = new Bookmark();
$sut->setName('foo-bar');
$this->assertEquals('foo-bar', $sut->getName());
self::assertEquals('foo-bar', $sut->getName());
$sut->setContent(['test' => 'foo-bar', 'hello' => 'world']);
$this->assertEquals(['test' => 'foo-bar', 'hello' => 'world'], $sut->getContent());
self::assertEquals(['test' => 'foo-bar', 'hello' => 'world'], $sut->getContent());
$sut->setType('sdsdsd');
$this->assertEquals('sdsdsd', $sut->getType());
self::assertEquals('sdsdsd', $sut->getType());
$user = new User();
$sut->setUser($user);
$this->assertEquals($user, $sut->getUser());
self::assertEquals($user, $sut->getUser());
$sut2 = clone $sut;
$this->assertEquals('sdsdsd', $sut2->getType());
$this->assertEquals('foo-bar', $sut2->getName());
self::assertEquals('sdsdsd', $sut2->getType());
self::assertEquals('foo-bar', $sut2->getName());
}
}

14
tests/Entity/ConfigurationTest.php
View File

@@ -20,17 +20,17 @@ class ConfigurationTest extends TestCase
public function testDefaultValues(): void
{
$sut = new Configuration();
$this->assertNull($sut->getId());
$this->assertNull($sut->getName());
$this->assertNull($sut->getValue());
self::assertNull($sut->getId());
self::assertNull($sut->getName());
self::assertNull($sut->getValue());
}
public function testSetterAndGetter(): void
{
$sut = new Configuration();
$this->assertInstanceOf(Configuration::class, $sut->setName('foo-bar'));
$this->assertEquals('foo-bar', $sut->getName());
$this->assertInstanceOf(Configuration::class, $sut->setValue('hello world'));
$this->assertEquals('hello world', $sut->getValue());
self::assertInstanceOf(Configuration::class, $sut->setName('foo-bar'));
self::assertEquals('foo-bar', $sut->getName());
self::assertInstanceOf(Configuration::class, $sut->setValue('hello world'));
self::assertEquals('hello world', $sut->getValue());
}
}

2
tests/Entity/CustomerCommentTest.php
View File

@@ -16,7 +16,7 @@ use App\Entity\CustomerComment;
* @covers \App\Entity\CustomerComment
* @covers \App\Entity\CommentTableTypeTrait
*/
class CustomerCommentTest extends AbstractCommentEntityTest
class CustomerCommentTest extends AbstractCommentEntityTestCase
{
protected function getEntity(): CustomerComment
{

2
tests/Entity/CustomerMetaTest.php
View File

@@ -18,7 +18,7 @@ use App\Entity\MetaTableTypeInterface;
/**
* @covers \App\Entity\CustomerMeta
*/
class CustomerMetaTest extends AbstractMetaEntityTest
class CustomerMetaTest extends AbstractMetaEntityTestCase
{
protected function getEntity(): EntityWithMetaFields
{

2
tests/Entity/CustomerTest.php
View File

@@ -20,7 +20,7 @@ use Doctrine\Common\Collections\Collection;
/**
* @covers \App\Entity\Customer
*/
class CustomerTest extends AbstractEntityTest
class CustomerTest extends AbstractEntityTestCase
{
public function testDefaultValues(): void
{

8
tests/Entity/EntityValidationTestTrait.php
View File

@@ -49,11 +49,11 @@ trait EntityValidationTestTrait
unset($violatedFields[$propertyPath]);
}
$this->assertTrue($foundField, 'Failed finding violation for field: ' . $propertyPath);
self::assertTrue($foundField, 'Failed finding violation for field: ' . $propertyPath);
}
$this->assertEmpty($violatedFields, \sprintf('Unexpected violations found: %s', implode(', ', $violatedFields)));
$this->assertEquals($expected, $countViolations, \sprintf('Expected %s violations, found %s in %s.', $expected, $actual, implode(', ', array_keys($violatedFields))));
self::assertEmpty($violatedFields, \sprintf('Unexpected violations found: %s', implode(', ', $violatedFields)));
self::assertEquals($expected, $countViolations, \sprintf('Expected %s violations, found %s in %s.', $expected, $actual, implode(', ', array_keys($violatedFields))));
}
public function assertHasNoViolations($entity, $groups = null): void
@@ -65,6 +65,6 @@ trait EntityValidationTestTrait
$violations = $validator->validate($entity, null, $groups);
$actual = $violations->count();
$this->assertEquals(0, $actual, \sprintf('Expected 0 violations, found %s.', $actual));
self::assertEquals(0, $actual, \sprintf('Expected 0 violations, found %s.', $actual));
}
}

2
tests/Entity/InvoiceMetaTest.php
View File

@@ -18,7 +18,7 @@ use App\Entity\MetaTableTypeInterface;
/**
* @covers \App\Entity\InvoiceMeta
*/
class InvoiceMetaTest extends AbstractMetaEntityTest
class InvoiceMetaTest extends AbstractMetaEntityTestCase
{
protected function getEntity(): EntityWithMetaFields
{

2
tests/Entity/ProjectCommentTest.php
View File

@@ -16,7 +16,7 @@ use App\Entity\ProjectComment;
* @covers \App\Entity\ProjectComment
* @covers \App\Entity\CommentTableTypeTrait
*/
class ProjectCommentTest extends AbstractCommentEntityTest
class ProjectCommentTest extends AbstractCommentEntityTestCase
{
protected function getEntity(): ProjectComment
{

2
tests/Entity/ProjectMetaTest.php
View File

@@ -18,7 +18,7 @@ use App\Entity\ProjectMeta;
/**
* @covers \App\Entity\ProjectMeta
*/
class ProjectMetaTest extends AbstractMetaEntityTest
class ProjectMetaTest extends AbstractMetaEntityTestCase
{
protected function getEntity(): EntityWithMetaFields
{

2
tests/Entity/ProjectTest.php
View File

@@ -21,7 +21,7 @@ use Doctrine\Common\Collections\Collection;
/**
* @covers \App\Entity\Project
*/
class ProjectTest extends AbstractEntityTest
class ProjectTest extends AbstractEntityTestCase
{
public function testDefaultValues(): void
{

22
tests/Entity/TagTest.php
View File

@@ -20,26 +20,26 @@ class TagTest extends TestCase
public function testDefaultValues(): void
{
$sut = new Tag();
$this->assertNull($sut->getId());
$this->assertNull($sut->getName());
$this->assertNull($sut->getColor());
self::assertNull($sut->getId());
self::assertNull($sut->getName());
self::assertNull($sut->getColor());
}
public function testSetterAndGetter(): void
{
$sut = new Tag();
$this->assertInstanceOf(Tag::class, $sut->setName('foo'));
$this->assertEquals('foo', $sut->getName());
$this->assertEquals('foo', (string) $sut);
self::assertInstanceOf(Tag::class, $sut->setName('foo'));
self::assertEquals('foo', $sut->getName());
self::assertEquals('foo', (string) $sut);
$sut->setName(null);
$this->assertNull($sut->getName());
$this->assertNull($sut->getColor());
$this->assertIsString($sut->getColorSafe());
self::assertNull($sut->getName());
self::assertNull($sut->getColor());
self::assertIsString($sut->getColorSafe());
$sut->setColor('#fffccc');
$this->assertEquals('#fffccc', $sut->getColor());
$this->assertEquals('#fffccc', $sut->getColorSafe());
self::assertEquals('#fffccc', $sut->getColor());
self::assertEquals('#fffccc', $sut->getColorSafe());
}
}

2
tests/Entity/TimesheetMetaTest.php
View File

@@ -18,7 +18,7 @@ use App\Entity\TimesheetMeta;
/**
* @covers \App\Entity\TimesheetMeta
*/
class TimesheetMetaTest extends AbstractMetaEntityTest
class TimesheetMetaTest extends AbstractMetaEntityTestCase
{
protected function getEntity(): EntityWithMetaFields
{

4
tests/Entity/TimesheetTest.php
View File

@@ -103,7 +103,7 @@ class TimesheetTest extends TestCase
$tag1 = new Tag();
$tag1->setName('foo');
$this->assertEmpty($sut->getTags());
self::assertEmpty($sut->getTags());
$sut->addTag($tag);
$sut->addTag($tag1);
@@ -115,7 +115,7 @@ class TimesheetTest extends TestCase
self::assertEquals([1 => 'foo'], $sut->getTagsAsArray());
$sut->removeTag($tag1);
$this->assertEmpty($sut->getTags());
self::assertEmpty($sut->getTags());
}
public function testMetaFields(): void

2
tests/Entity/UserTest.php
View File

@@ -33,7 +33,7 @@ class UserTest extends TestCase
$user = new User();
self::assertInstanceOf(EquatableInterface::class, $user);
self::assertInstanceOf(UserInterface::class, $user);
$this->assertInstanceOf(ArrayCollection::class, $user->getPreferences());
self::assertInstanceOf(ArrayCollection::class, $user->getPreferences());
self::assertNull($user->getTitle());
self::assertNull($user->getAvatar());
self::assertNull($user->getAlias());

4
tests/Entity/UserValidationTest.php
View File

@@ -20,7 +20,7 @@ class UserValidationTest extends KernelTestCase
{
use EntityValidationTestTrait;
public function getInvalidTestData()
public static function getInvalidTestData()
{
return [
['', ''],
@@ -69,7 +69,7 @@ class UserValidationTest extends KernelTestCase
$this->assertHasNoViolations($user, ['RolesUpdate']);
}
public function getValidTestData()
public static function getValidTestData()
{
return [
[str_pad('#', 8, '-'), 'test@x.x'], // shortest possible username