jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

simplify to add widgets via plugin (#1308)

Browse Source
This commit is contained in:
Kevin Papst
2019-12-06 23:36:03 +01:00
committed by GitHub
parent 5b0266c462
commit d62e1c4468
4 changed files with 30 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Widget/Renderer/SimpleWidgetRenderer.php
View File

@@ -11,7 +11,6 @@ namespace App\Widget\Renderer;
use App\Widget\Type\SimpleWidget; use App\Widget\Type\SimpleWidget;
use App\Widget\WidgetInterface; use App\Widget\WidgetInterface;
use ReflectionClass;
class SimpleWidgetRenderer extends AbstractTwigRenderer class SimpleWidgetRenderer extends AbstractTwigRenderer
{ {
@@ -20,11 +19,18 @@ class SimpleWidgetRenderer extends AbstractTwigRenderer
return $widget instanceof SimpleWidget; return $widget instanceof SimpleWidget;
} }
/**
* @param SimpleWidget $widget
* @param array $options
* @return string
* @throws \ReflectionException
* @throws \Twig\Error\LoaderError
* @throws \Twig\Error\RuntimeError
* @throws \Twig\Error\SyntaxError
*/
public function render(WidgetInterface $widget, array $options = []): string public function render(WidgetInterface $widget, array $options = []): string
{ {
$name = (new ReflectionClass($widget))->getShortName(); return $this->renderTemplate($widget->getTemplateName(), [
return $this->renderTemplate(sprintf('widget/widget-%s.html.twig', strtolower($name)), [
'data' => $widget->getData($options), 'data' => $widget->getData($options),
'options' => $widget->getOptions($options), 'options' => $widget->getOptions($options),
'title' => $widget->getTitle(), 'title' => $widget->getTitle(),

6
src/Widget/Type/SimpleWidget.php
View File

@@ -11,4 +11,10 @@ namespace App\Widget\Type;
class SimpleWidget extends AbstractWidgetType class SimpleWidget extends AbstractWidgetType
{ {
public function getTemplateName(): string
{
$name = (new \ReflectionClass($this))->getShortName();
return sprintf('widget/widget-%s.html.twig', strtolower($name));
}
} }

7
tests/Widget/Type/CounterTest.php
View File

@@ -15,6 +15,7 @@ use App\Widget\Type\SimpleWidget;
/** /**
* @covers \App\Widget\Type\Counter * @covers \App\Widget\Type\Counter
* @covers \App\Widget\Type\SimpleWidget
*/ */
class CounterTest extends AbstractWidgetTypeTest class CounterTest extends AbstractWidgetTypeTest
{ {
@@ -33,4 +34,10 @@ class CounterTest extends AbstractWidgetTypeTest
$sut = $this->createSut(); $sut = $this->createSut();
self::assertInstanceOf(SimpleWidget::class, $sut); self::assertInstanceOf(SimpleWidget::class, $sut);
} }
public function testTemplateName()
{
$sut = new Counter();
self::assertEquals('widget/widget-counter.html.twig', $sut->getTemplateName());
}
} }

7
tests/Widget/Type/MoreTest.php
View File

@@ -15,6 +15,7 @@ use App\Widget\Type\SimpleWidget;
/** /**
* @covers \App\Widget\Type\More * @covers \App\Widget\Type\More
* @covers \App\Widget\Type\SimpleWidget
*/ */
class MoreTest extends AbstractWidgetTypeTest class MoreTest extends AbstractWidgetTypeTest
{ {
@@ -33,4 +34,10 @@ class MoreTest extends AbstractWidgetTypeTest
$sut = $this->createSut(); $sut = $this->createSut();
self::assertInstanceOf(SimpleWidget::class, $sut); self::assertInstanceOf(SimpleWidget::class, $sut);
} }
public function testTemplateName()
{
$sut = new More();
self::assertEquals('widget/widget-more.html.twig', $sut->getTemplateName());
}
} }