Release 2.34 (#5465)

* fix timing issue in timesheet edit form with deactivated rounding
* bump packages
* only show update messages for newer plugin versions
* replace deprecated method
* remove internal from API
* remove technical terms from translation
* prevent calls to internal symfony methods
* helper method to flag entry as modified
* support meta-fields in weekly-hourse view
* fix running timesheets were deleted in weekly-hourse

src/Ldap/LdapCredentialsSubscriber.php

@@ -13,12 +13,11 @@ use App\Entity\User;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Security\Core\Exception\BadCredentialsException;
 use Symfony\Component\Security\Http\Authenticator\Passport\Credentials\PasswordCredentials;
-use Symfony\Component\Security\Http\Authenticator\Passport\Passport;
 use Symfony\Component\Security\Http\Event\CheckPassportEvent;
 
 final class LdapCredentialsSubscriber implements EventSubscriberInterface
 {
-    public function __construct(private LdapManager $ldapManager)
+    public function __construct(private readonly LdapManager $ldapManager)
     {
     }
 
@@ -40,7 +39,7 @@ final class LdapCredentialsSubscriber implements EventSubscriberInterface
             return;
         }
 
-        if (!$passport instanceof Passport || !$passport->hasBadge(PasswordCredentials::class)) {
+        if (!$passport->hasBadge(PasswordCredentials::class)) {
             throw new \LogicException(\sprintf('LDAP authentication requires a passport containing a user and password credentials, authenticator "%s" does not fulfill these requirements.', \get_class($event->getAuthenticator())));
         }
 
@@ -78,6 +77,6 @@ final class LdapCredentialsSubscriber implements EventSubscriberInterface
         }
 
         // make sure that the normal auth process is not triggered
-        $passwordCredentials->markResolved();
+        $passwordCredentials->markResolved(); // @phpstan-ignore method.internal
     }
 }