jjsm01/kimai2
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix non-ascii character break invoice download (#1592)

Browse Source
This commit is contained in:
Kevin Papst
2020-03-27 00:55:23 +01:00
committed by GitHub
parent 33f76f426c
commit 163fb1be4a
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Invoice/InvoiceFilename.php
View File

@@ -30,8 +30,8 @@ final class InvoiceFilename
}
if (!empty($company)) {
$company = new UnicodeString($company);
$filename .= '-' . $company->snake();
$uCompany = new UnicodeString($company);
$filename .= '-' . $uCompany->ascii()->snake();
}
$this->filename = $filename;

12
tests/Invoice/InvoiceFilenameTest.php
View File

@@ -47,7 +47,15 @@ class InvoiceFilenameTest extends TestCase
$customer->setCompany('barß / laölala # ldksjf 123');
$sut = new InvoiceFilename($model);
self::assertEquals($datePrefix . '-barß_laölala_ldksjf123', $sut->getFilename());
self::assertEquals($datePrefix . '-barß_laölala_ldksjf123', (string) $sut);
self::assertEquals($datePrefix . '-barss_laolala_ldksjf123', $sut->getFilename());
self::assertEquals($datePrefix . '-barss_laolala_ldksjf123', (string) $sut);
$customer->setCompany('까깨꺄꺠꺼께껴꼐꼬꽈sssss');
$sut = new InvoiceFilename($model);
self::assertEquals($datePrefix . '-kkakkaekkyakkyaekkeokkekkyeokkyekkokkwasssss', $sut->getFilename());
$customer->setCompany('\"#+ß.!$%&/()=?\\n=/*-+´_<>@' . "\n");
$sut = new InvoiceFilename($model);
self::assertEquals($datePrefix . '-ss_n', $sut->getFilename());
}
}