release 1.19 (#3215)

.github_changelog_generator

@@ -1,5 +1,5 @@
 unreleased=true
-future-release=1.18
+future-release=1.19
 exclude-labels=duplicate,support,question,invalid,wontfix,release,waiting for feedback,documentation
 enhancement_labels=>enhancement,Enhancement,feature request,translation i18n,technical debt,documentation
 issues-wo-labels=false

SECURITY.md

@@ -7,8 +7,8 @@ As announced in the [README](README.md) I only support the latest available rele
 | Version | Supported          |
 |---------|--------------------|
 | master  | :white_check_mark: |
-| 1.18    | :white_check_mark: |
-| < 1.18  | :x:                |
+| 1.19    | :white_check_mark: |
+| < 1.19  | :x:                |
 
 ## Reporting a Vulnerability
 

src/Constants.php

@@ -17,11 +17,11 @@ class Constants
     /**
      * The current release version
      */
-    public const VERSION = '1.18.3';
+    public const VERSION = '1.19';
     /**
      * The current release: major * 10000 + minor * 100 + patch
      */
-    public const VERSION_ID = 11803;
+    public const VERSION_ID = 11900;
     /**
      * The current release status, either "stable" or "dev"
      */

src/DataFixtures/TagFixtures.php

@@ -43,11 +43,9 @@ class TagFixtures extends Fixture
             $tag = new Tag();
 
             $tagName = null;
-            if ($i % 2 == 9) {
-                $tagName = $faker->companyEmail;
-            } elseif ($i % 2 == 8) {
+            if ($i % 18 == 0) {
                 $tagName = $faker->firstName;
-            } elseif ($i % 2 == 7) {
+            } elseif ($i % 7 == 0) {
                 $tagName = $faker->lastName;
             } elseif ($i % 5 == 0) {
                 $tagName = $faker->city;

src/Model/MonthlyStatistic.php

@@ -17,7 +17,7 @@ use DateTimeInterface;
 final class MonthlyStatistic implements DateStatisticInterface
 {
     /**
-     * @var array<string, array<int, StatisticDate>>
+     * @var array<string|int, array<int<1, 12>, StatisticDate>>
      */
     private $years = [];
     private $begin;

src/Validator/Constraints/HexColorValidator.php

@@ -26,7 +26,7 @@ class HexColorValidator extends ConstraintValidator
 
         $color = $value;
 
-        if ($color === null || (\is_string($color) && empty($color))) {
+        if ($color === null || $color === '') {
             return;
         }
 

tests/Model/UserStatisticTest.php

@@ -74,7 +74,7 @@ class UserStatisticTest extends AbstractTimesheetCountedStatisticTest
 
         self::assertSame(145, $sut->getDuration());
         self::assertSame(1468, $sut->getDurationBillable());
-        self::assertSame(669.64, $sut->getRate());
+        self::assertSame(669.64, round($sut->getRate(), 2));
         self::assertSame(580.236, $sut->getRateBillable());
         self::assertSame(1134.98, $sut->getInternalRate());
     }