technical debts (#3438)

* reformat release notes * deactivate transactions in migrations by default * fix migration base class * fix default value * composer update
2022-07-27 00:54:43 +02:00
parent 1b8948a086
commit 7238f404f7
9 changed files with 76 additions and 73 deletions
--- a/.github/release-drafter.yml
+++ b/.github/release-drafter.yml
@@ -16,17 +16,16 @@ exclude-labels:
    - 'duplicate'
    - 'invalid'
    - 'wontfix'
+    - 'release'
 exclude-contributors:
    - 'dependabot'
 change-template: '- $TITLE (#$NUMBER)'
 change-title-escapes: '\<*_&`#@'
 version-resolver:
-    major:
-        labels:
-            - 'release'
    minor:
        labels:
            - 'feature request'
+            - 'release'
    patch:
        labels:
            - 'technical debt'
@@ -34,14 +33,14 @@ version-resolver:
            - 'translation'
    default: patch
 template: |
-  [Upgrade Kimai](https://www.kimai.org/documentation/updates.html) - [Install Kimai](https://www.kimai.org/documentation/installation.html) - [Docker](https://tobybatch.github.io/kimai2/)
-
-  **PHP Version compatibility:**
+    [Upgrade Kimai](https://www.kimai.org/documentation/updates.html) - [Install Kimai](https://www.kimai.org/documentation/installation.html) - [Docker](https://tobybatch.github.io/kimai2/)
+    
+    **PHP Version compatibility:**
    - PHP 7.3 is [end-of-life](https://www.php.net/supported-versions.php): you need to update now
    - PHP 7.4, PHP 8 and PHP 8.1 are supported
-
-  $CHANGES
-
-  Thanks to all contributors ❤️ 
-
+    
+    $CHANGES
+    
+    Thanks to all contributors ❤️ 
+    
    Involved in this release: $CONTRIBUTORS
--- a/composer.lock
+++ b/composer.lock
@@ -187,16 +187,16 @@
        },
        {
            "name": "doctrine/annotations",
-            "version": "1.13.2",
+            "version": "1.13.3",
            "source": {
                "type": "git",
                "url": "https://github.com/doctrine/annotations.git",
-                "reference": "5b668aef16090008790395c02c893b1ba13f7e08"
+                "reference": "648b0343343565c4a056bfc8392201385e8d89f0"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/doctrine/annotations/zipball/5b668aef16090008790395c02c893b1ba13f7e08",
-                "reference": "5b668aef16090008790395c02c893b1ba13f7e08",
+                "url": "https://api.github.com/repos/doctrine/annotations/zipball/648b0343343565c4a056bfc8392201385e8d89f0",
+                "reference": "648b0343343565c4a056bfc8392201385e8d89f0",
                "shasum": ""
            },
            "require": {
@@ -208,9 +208,10 @@
            "require-dev": {
                "doctrine/cache": "^1.11 || ^2.0",
                "doctrine/coding-standard": "^6.0 || ^8.1",
-                "phpstan/phpstan": "^0.12.20",
+                "phpstan/phpstan": "^1.4.10 || ^1.8.0",
                "phpunit/phpunit": "^7.5 || ^8.0 || ^9.1.5",
-                "symfony/cache": "^4.4 || ^5.2"
+                "symfony/cache": "^4.4 || ^5.2",
+                "vimeo/psalm": "^4.10"
            },
            "type": "library",
            "autoload": {
@@ -253,9 +254,9 @@
            ],
            "support": {
                "issues": "https://github.com/doctrine/annotations/issues",
-                "source": "https://github.com/doctrine/annotations/tree/1.13.2"
+                "source": "https://github.com/doctrine/annotations/tree/1.13.3"
            },
-            "time": "2021-08-05T19:00:23+00:00"
+            "time": "2022-07-02T10:48:51+00:00"
        },
        {
            "name": "doctrine/cache",
@@ -1952,16 +1953,16 @@
        },
        {
            "name": "gedmo/doctrine-extensions",
-            "version": "v3.7.0",
+            "version": "v3.8.0",
            "source": {
                "type": "git",
                "url": "https://github.com/doctrine-extensions/DoctrineExtensions.git",
-                "reference": "42d9acf02281bb46f9b741f4a9f033e3453e2d36"
+                "reference": "4ba5377b1a1d9a988205c4e37f5d5287eb8ebd28"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/doctrine-extensions/DoctrineExtensions/zipball/42d9acf02281bb46f9b741f4a9f033e3453e2d36",
-                "reference": "42d9acf02281bb46f9b741f4a9f033e3453e2d36",
+                "url": "https://api.github.com/repos/doctrine-extensions/DoctrineExtensions/zipball/4ba5377b1a1d9a988205c4e37f5d5287eb8ebd28",
+                "reference": "4ba5377b1a1d9a988205c4e37f5d5287eb8ebd28",
                "shasum": ""
            },
            "require": {
@@ -2052,10 +2053,10 @@
            "support": {
                "email": "gediminas.morkevicius@gmail.com",
                "issues": "https://github.com/doctrine-extensions/DoctrineExtensions/issues",
-                "source": "https://github.com/doctrine-extensions/DoctrineExtensions/tree/v3.7.0",
+                "source": "https://github.com/doctrine-extensions/DoctrineExtensions/tree/v3.8.0",
                "wiki": "https://github.com/Atlantic18/DoctrineExtensions/tree/main/doc"
            },
-            "time": "2022-05-17T06:58:52+00:00"
+            "time": "2022-07-17T12:04:16+00:00"
        },
        {
            "name": "handcraftedinthealps/rest-routing-bundle",
@@ -3978,16 +3979,16 @@
        },
        {
            "name": "phpoffice/phpspreadsheet",
-            "version": "1.23.0",
+            "version": "1.24.1",
            "source": {
                "type": "git",
                "url": "https://github.com/PHPOffice/PhpSpreadsheet.git",
-                "reference": "21e4cf62699eebf007db28775f7d1554e612ed9e"
+                "reference": "69991111e05fca3ff7398e1e7fca9ebed33efec6"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/PHPOffice/PhpSpreadsheet/zipball/21e4cf62699eebf007db28775f7d1554e612ed9e",
-                "reference": "21e4cf62699eebf007db28775f7d1554e612ed9e",
+                "url": "https://api.github.com/repos/PHPOffice/PhpSpreadsheet/zipball/69991111e05fca3ff7398e1e7fca9ebed33efec6",
+                "reference": "69991111e05fca3ff7398e1e7fca9ebed33efec6",
                "shasum": ""
            },
            "require": {
@@ -4015,15 +4016,15 @@
            },
            "require-dev": {
                "dealerdirect/phpcodesniffer-composer-installer": "dev-master",
-                "dompdf/dompdf": "^1.0",
+                "dompdf/dompdf": "^1.0 || ^2.0",
                "friendsofphp/php-cs-fixer": "^3.2",
                "jpgraph/jpgraph": "^4.0",
-                "mpdf/mpdf": "8.0.17",
+                "mpdf/mpdf": "8.1.1",
                "phpcompatibility/php-compatibility": "^9.3",
                "phpstan/phpstan": "^1.1",
                "phpstan/phpstan-phpunit": "^1.0",
                "phpunit/phpunit": "^8.5 || ^9.0",
-                "squizlabs/php_codesniffer": "^3.6",
+                "squizlabs/php_codesniffer": "^3.7",
                "tecnickcom/tcpdf": "^6.4"
            },
            "suggest": {
@@ -4076,9 +4077,9 @@
            ],
            "support": {
                "issues": "https://github.com/PHPOffice/PhpSpreadsheet/issues",
-                "source": "https://github.com/PHPOffice/PhpSpreadsheet/tree/1.23.0"
+                "source": "https://github.com/PHPOffice/PhpSpreadsheet/tree/1.24.1"
            },
-            "time": "2022-04-24T13:53:10+00:00"
+            "time": "2022-07-18T19:50:48+00:00"
        },
        {
            "name": "phpoffice/phpword",
@@ -10099,16 +10100,16 @@
        },
        {
            "name": "symfony/webpack-encore-bundle",
-            "version": "v1.14.1",
+            "version": "v1.15.1",
            "source": {
                "type": "git",
                "url": "https://github.com/symfony/webpack-encore-bundle.git",
-                "reference": "6b18be99bf2a5a402b80a2c00043fe0b365fe836"
+                "reference": "718673b1e758533614190ae74d07305a72bc66a9"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/symfony/webpack-encore-bundle/zipball/6b18be99bf2a5a402b80a2c00043fe0b365fe836",
-                "reference": "6b18be99bf2a5a402b80a2c00043fe0b365fe836",
+                "url": "https://api.github.com/repos/symfony/webpack-encore-bundle/zipball/718673b1e758533614190ae74d07305a72bc66a9",
+                "reference": "718673b1e758533614190ae74d07305a72bc66a9",
                "shasum": ""
            },
            "require": {
@@ -10116,7 +10117,9 @@
                "symfony/asset": "^4.4 || ^5.0 || ^6.0",
                "symfony/config": "^4.4 || ^5.0 || ^6.0",
                "symfony/dependency-injection": "^4.4 || ^5.0 || ^6.0",
+                "symfony/deprecation-contracts": "^2.1 || ^3.0",
                "symfony/http-kernel": "^4.4 || ^5.0 || ^6.0",
+                "symfony/polyfill-php80": "^1.25.0",
                "symfony/service-contracts": "^1.0 || ^2.0 || ^3.0"
            },
            "require-dev": {
@@ -10150,7 +10153,7 @@
            "description": "Integration with your Symfony app & Webpack Encore!",
            "support": {
                "issues": "https://github.com/symfony/webpack-encore-bundle/issues",
-                "source": "https://github.com/symfony/webpack-encore-bundle/tree/v1.14.1"
+                "source": "https://github.com/symfony/webpack-encore-bundle/tree/v1.15.1"
            },
            "funding": [
                {
@@ -10166,7 +10169,7 @@
                    "type": "tidelift"
                }
            ],
-            "time": "2022-05-03T17:55:32+00:00"
+            "time": "2022-07-13T17:07:35+00:00"
        },
        {
            "name": "symfony/yaml",
@@ -11405,16 +11408,16 @@
        },
        {
            "name": "fakerphp/faker",
-            "version": "v1.19.0",
+            "version": "v1.20.0",
            "source": {
                "type": "git",
                "url": "https://github.com/FakerPHP/Faker.git",
-                "reference": "d7f08a622b3346766325488aa32ddc93ccdecc75"
+                "reference": "37f751c67a5372d4e26353bd9384bc03744ec77b"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/FakerPHP/Faker/zipball/d7f08a622b3346766325488aa32ddc93ccdecc75",
-                "reference": "d7f08a622b3346766325488aa32ddc93ccdecc75",
+                "url": "https://api.github.com/repos/FakerPHP/Faker/zipball/37f751c67a5372d4e26353bd9384bc03744ec77b",
+                "reference": "37f751c67a5372d4e26353bd9384bc03744ec77b",
                "shasum": ""
            },
            "require": {
@@ -11441,7 +11444,7 @@
            "type": "library",
            "extra": {
                "branch-alias": {
-                    "dev-main": "v1.19-dev"
+                    "dev-main": "v1.20-dev"
                }
            },
            "autoload": {
@@ -11466,9 +11469,9 @@
            ],
            "support": {
                "issues": "https://github.com/FakerPHP/Faker/issues",
-                "source": "https://github.com/FakerPHP/Faker/tree/v1.19.0"
+                "source": "https://github.com/FakerPHP/Faker/tree/v1.20.0"
            },
-            "time": "2022-02-02T17:38:57+00:00"
+            "time": "2022-07-20T13:12:54+00:00"
        },
        {
            "name": "friendsofphp/php-cs-fixer",
@@ -11847,16 +11850,16 @@
        },
        {
            "name": "phpstan/phpstan",
-            "version": "1.8.0",
+            "version": "1.8.2",
            "source": {
                "type": "git",
                "url": "https://github.com/phpstan/phpstan.git",
-                "reference": "b7648d4ee9321665acaf112e49da9fd93df8fbd5"
+                "reference": "c53312ecc575caf07b0e90dee43883fdf90ca67c"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/phpstan/phpstan/zipball/b7648d4ee9321665acaf112e49da9fd93df8fbd5",
-                "reference": "b7648d4ee9321665acaf112e49da9fd93df8fbd5",
+                "url": "https://api.github.com/repos/phpstan/phpstan/zipball/c53312ecc575caf07b0e90dee43883fdf90ca67c",
+                "reference": "c53312ecc575caf07b0e90dee43883fdf90ca67c",
                "shasum": ""
            },
            "require": {
@@ -11882,7 +11885,7 @@
            "description": "PHPStan - PHP Static Analysis Tool",
            "support": {
                "issues": "https://github.com/phpstan/phpstan/issues",
-                "source": "https://github.com/phpstan/phpstan/tree/1.8.0"
+                "source": "https://github.com/phpstan/phpstan/tree/1.8.2"
            },
            "funding": [
                {
@@ -11902,25 +11905,25 @@
                    "type": "tidelift"
                }
            ],
-            "time": "2022-06-29T08:53:31+00:00"
+            "time": "2022-07-20T09:57:31+00:00"
        },
        {
            "name": "phpstan/phpstan-doctrine",
-            "version": "1.3.9",
+            "version": "1.3.11",
            "source": {
                "type": "git",
                "url": "https://github.com/phpstan/phpstan-doctrine.git",
-                "reference": "e0281f8acec4ca743403b959885315508c9b3351"
+                "reference": "3ef6399761bb33fdfa0d5546d4b6e7d8811e8850"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/phpstan/phpstan-doctrine/zipball/e0281f8acec4ca743403b959885315508c9b3351",
-                "reference": "e0281f8acec4ca743403b959885315508c9b3351",
+                "url": "https://api.github.com/repos/phpstan/phpstan-doctrine/zipball/3ef6399761bb33fdfa0d5546d4b6e7d8811e8850",
+                "reference": "3ef6399761bb33fdfa0d5546d4b6e7d8811e8850",
                "shasum": ""
            },
            "require": {
                "php": "^7.2 || ^8.0",
-                "phpstan/phpstan": "^1.7.3"
+                "phpstan/phpstan": "^1.8.0"
            },
            "conflict": {
                "doctrine/collections": "<1.0",
@@ -11968,9 +11971,9 @@
            "description": "Doctrine extensions for PHPStan",
            "support": {
                "issues": "https://github.com/phpstan/phpstan-doctrine/issues",
-                "source": "https://github.com/phpstan/phpstan-doctrine/tree/1.3.9"
+                "source": "https://github.com/phpstan/phpstan-doctrine/tree/1.3.11"
            },
-            "time": "2022-06-06T09:18:01+00:00"
+            "time": "2022-07-20T14:54:37+00:00"
        },
        {
            "name": "phpstan/phpstan-phpunit",
@@ -12026,22 +12029,22 @@
        },
        {
            "name": "phpstan/phpstan-symfony",
-            "version": "1.2.5",
+            "version": "1.2.8",
            "source": {
                "type": "git",
                "url": "https://github.com/phpstan/phpstan-symfony.git",
-                "reference": "85be852a17fd5a6b67d4fc6daed21e794f935b2d"
+                "reference": "28fe677ec3ad43eb4c0946c502535365e3040ecf"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/phpstan/phpstan-symfony/zipball/85be852a17fd5a6b67d4fc6daed21e794f935b2d",
-                "reference": "85be852a17fd5a6b67d4fc6daed21e794f935b2d",
+                "url": "https://api.github.com/repos/phpstan/phpstan-symfony/zipball/28fe677ec3ad43eb4c0946c502535365e3040ecf",
+                "reference": "28fe677ec3ad43eb4c0946c502535365e3040ecf",
                "shasum": ""
            },
            "require": {
                "ext-simplexml": "*",
                "php": "^7.2 || ^8.0",
-                "phpstan/phpstan": "^1.6"
+                "phpstan/phpstan": "^1.8.2"
            },
            "conflict": {
                "symfony/framework-bundle": "<3.0"
@@ -12091,9 +12094,9 @@
            "description": "Symfony Framework extensions and rules for PHPStan",
            "support": {
                "issues": "https://github.com/phpstan/phpstan-symfony/issues",
-                "source": "https://github.com/phpstan/phpstan-symfony/tree/1.2.5"
+                "source": "https://github.com/phpstan/phpstan-symfony/tree/1.2.8"
            },
-            "time": "2022-06-10T08:44:35+00:00"
+            "time": "2022-07-20T12:02:52+00:00"
        },
        {
            "name": "phpunit/php-code-coverage",
--- a/config/packages/doctrine_migrations.yaml
+++ b/config/packages/doctrine_migrations.yaml
@@ -6,3 +6,4 @@ doctrine_migrations:
        # namespace is arbitrary but should be different from App\Migrations
        # as migrations classes should NOT be autoloaded
        'DoctrineMigrations': '%kernel.project_dir%/src/Migrations'
+    transactional: false
--- a/src/Entity/Activity.php
+++ b/src/Entity/Activity.php
@@ -131,7 +131,7 @@ class Activity implements EntityWithMetaFields, EntityWithBudget
     *
     * @Exporter\Expose(label="label.billable", type="boolean")
     *
-     * @ORM\Column(name="billable", type="boolean", nullable=false)
+     * @ORM\Column(name="billable", type="boolean", nullable=false, options={"default": true})
     * @Assert\NotNull()
     */
    private $billable = true;
--- a/src/Entity/Customer.php
+++ b/src/Entity/Customer.php
@@ -106,7 +106,7 @@ class Customer implements EntityWithMetaFields, EntityWithBudget
     *
     * @Exporter\Expose(label="label.billable", type="boolean")
     *
-     * @ORM\Column(name="billable", type="boolean", nullable=false)
+     * @ORM\Column(name="billable", type="boolean", nullable=false, options={"default": true})
     * @Assert\NotNull()
     */
    private $billable = true;
--- a/src/Entity/Project.php
+++ b/src/Entity/Project.php
@@ -203,7 +203,7 @@ class Project implements EntityWithMetaFields, EntityWithBudget
     *
     * @Exporter\Expose(label="label.billable", type="boolean")
     *
-     * @ORM\Column(name="billable", type="boolean", nullable=false)
+     * @ORM\Column(name="billable", type="boolean", nullable=false, options={"default": true})
     * @Assert\NotNull()
     */
    private $billable = true;
--- a/src/Migrations/Version20210320162820.php
+++ b/src/Migrations/Version20210320162820.php
@@ -11,8 +11,8 @@ declare(strict_types=1);

 namespace DoctrineMigrations;

+use App\Doctrine\AbstractMigration;
 use Doctrine\DBAL\Schema\Schema;
-use Doctrine\Migrations\AbstractMigration;

 /**
 * Update invoice with payment date
--- a/src/Migrations/Version20210719123928.php
+++ b/src/Migrations/Version20210719123928.php
@@ -11,8 +11,8 @@ declare(strict_types=1);

 namespace DoctrineMigrations;

+use App\Doctrine\AbstractMigration;
 use Doctrine\DBAL\Schema\Schema;
-use Doctrine\Migrations\AbstractMigration;

 /**
 * @version 1.15
--- a/src/Migrations/Version20220531145920.php
+++ b/src/Migrations/Version20220531145920.php
@@ -11,8 +11,8 @@ declare(strict_types=1);

 namespace DoctrineMigrations;

+use App\Doctrine\AbstractMigration;
 use Doctrine\DBAL\Schema\Schema;
-use Doctrine\Migrations\AbstractMigration;

 /**
 * @version 1.20.2