Improve allowed running records (#528)

src/API/TimesheetController.php

@@ -194,10 +194,13 @@ class TimesheetController extends BaseApiController
                 }
             }
 
-            $this->repository->stopActiveEntries(
-                $timesheet->getUser(),
-                $this->hardLimit
-            );
+            if (null === $timesheet->getEnd()) {
+                $this->repository->stopActiveEntries(
+                    $timesheet->getUser(),
+                    $this->hardLimit
+                );
+            }
+
             $entityManager = $this->getDoctrine()->getManager();
             $entityManager->persist($timesheet);
             $entityManager->flush();

src/Controller/TimesheetController.php

@@ -165,11 +165,12 @@ class TimesheetController extends AbstractController
             if (count($errors) > 0) {
                 $this->flashError('timesheet.start.error', ['%reason%' => $errors[0]->getPropertyPath() . ' = ' . $errors[0]->getMessage()]);
             } else {
-                $entityManager = $this->getDoctrine()->getManager();
-                $entityManager->persist($entry);
                 $this->stopActiveEntries($user);
 
+                $entityManager = $this->getDoctrine()->getManager();
+                $entityManager->persist($entry);
                 $entityManager->flush();
+
                 $this->flashSuccess('timesheet.start.success');
             }
         } catch (\Exception $ex) {

src/Controller/TimesheetControllerTrait.php

@@ -172,7 +172,9 @@ trait TimesheetControllerTrait
             $entityManager = $this->getDoctrine()->getManager();
 
             try {
-                $this->stopActiveEntries($entry->getUser());
+                if (null === $entry->getEnd()) {
+                    $this->stopActiveEntries($entry->getUser());
+                }
                 $entityManager->persist($entry);
                 $entityManager->flush();
 

templates/calendar/user.html.twig

@@ -5,7 +5,7 @@
 
 {% block page_title %}{{ 'calendar.title'|trans }}{% endblock %}
 {% block page_subtitle %}{{ 'calendar.subtitle'|trans }}{% endblock %}
-{% block page_actions %}{{ widgets.page_actions({'list': path('timesheet'), 'create': path('timesheet_create')}) }}{% endblock %}
+{% block page_actions %}{{ widgets.page_actions({'list': path('timesheet'), 'create': path('timesheet_create', {'origin': 'calendar'})}) }}{% endblock %}
 
 {% block main %}
     <div class="row">