do not apply rate factor multiple times (#2807)

2021-10-03 17:40:36 +02:00
parent b6430d5622
commit ea415e33f5
1 changed files with 5 additions and 1 deletions
--- a/src/Timesheet/RateService.php
+++ b/src/Timesheet/RateService.php
@@ -85,7 +85,11 @@ final class RateService implements RateServiceInterface
            }
        }

-        $factor = $this->getRateFactor($record);
+        $factor = 1.00;
+        // do not apply once a value was calculated - see https://github.com/kevinpapst/kimai2/issues/1988
+        if ($record->getFixedRate() === null && $record->getHourlyRate() === null) {
+            $factor = $this->getRateFactor($record);
+        }

        $factoredHourlyRate = (float) ($hourlyRate * $factor);
        $factoredInternalRate = (float) ($internalRate * $factor);